Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing default keys from language files #197

Open
raikasdev opened this issue Mar 3, 2023 · 1 comment
Open

Removing default keys from language files #197

raikasdev opened this issue Mar 3, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@raikasdev
Copy link

Related problem or need

My resource pack uses language JSON files, but they also contain a lot of keys that are identical to the one's in Vanilla.

Proposed solution

PackSquash would compare language JSON values to the defaults from Minecraft, and remove identical keys.

Alternative solutions

Just keep them in.

Additional context

No response

@raikasdev raikasdev added the enhancement New feature or request label Mar 3, 2023
@AlexTMjugador AlexTMjugador added the good first issue Good for newcomers label Mar 3, 2023
@AlexTMjugador
Copy link
Member

AlexTMjugador commented Mar 3, 2023

Thank you for suggesting this improvement! ❤️ I think that the described optimization can be significant and not too hard to implement, although it relies on PackSquash knowing data about vanilla Minecraft version ranges, which depends on a refactor that is being worked on for v0.4.0.

Nevertheless, I'd like to work on this some day, or accept pull requests for it. If someone is interested in sending a PR before v0.4.0 is released, please contact me over Discord to discuss how to coordinate work first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Accepted ideas
Development

No branches or pull requests

2 participants