Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain parameters v3 #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add chain parameters v3 #66

wants to merge 2 commits into from

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Nov 20, 2024 •
edited
Loading

Purpose

Add chain parameters version 3 to the definitions, containing the new ValidatorsScoreParameters parameters.

Changes

See above.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 requested a review from td202 November 21, 2024 12:09
@drsk0 drsk0 force-pushed the chain_parameters_v3 branch 2 times, most recently from 0ece01b to 5ef4cbf Compare November 21, 2024 12:23
td202
td202 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please hold off merging until corresponding PRs for base and node are also ready.

v2/concordium/types.proto Outdated Show resolved Hide resolved
@drsk0 @td202
Update v2/concordium/types.proto
cf87e1d 
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
@drsk0 drsk0 mentioned this pull request Nov 25, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@td202 td202 td202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drsk0 @td202