Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paramgen sets the type 'string' for array fields #137

Open
hariso opened this issue Nov 14, 2024 · 4 comments
Open

paramgen sets the type 'string' for array fields #137

hariso opened this issue Nov 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@hariso
Copy link
Contributor

hariso commented Nov 14, 2024

Bug description

If a config struct contains an array field, e.g.

MyIntArray   [3]int

then paramgen generates the type string for this field.

Steps to reproduce

See description.

Version

v0.5.0

@simonl2002
Copy link
Member

@hariso is this related to current work? Should we pull this in?

@hariso
Copy link
Contributor Author

hariso commented Dec 3, 2024

@simonl2002 It isn't, the issue is present when specgen is not used too. To my knowledge, arrays are rarely used in Go code, so no need to pull this in right now.

@lovromazgon
Copy link
Member

When would we actually want to use a fixed-size array in a config? 🤔

@hariso hariso removed the triage Needs to be triaged label Jan 13, 2025
@hariso
Copy link
Contributor Author

hariso commented Jan 13, 2025

When would we actually want to use a fixed-size array in a config? 🤔

My guess is rarely (but I've still opened because it's a valid type). That's why we removed it from the board (I just noticed we didn't remove the triage label). In the Go code I've read so far, I haven't seen more than a handful arrays.:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants