Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add acceptance test to ensure connectors can be opened and immediately closed #134

Open
alarbada opened this issue May 20, 2024 · 0 comments
Labels
feature New feature or request

Comments

@alarbada
Copy link
Contributor

Feature description

When developing the kinesis connector I got the following error:

  acceptance_test.go:221: err: error deregistering stream consumer arn:aws:kinesis:us-east-1:000000000000:stream/acceptance_2603d625/consumer/conduit-connector-kinesis-source-01HYBHT28ZYD0F7NJHGQRZFRZA:1716223323: operation error Kinesis: DeregisterStreamConsumer, https response error StatusCode: 400, RequestID: 04399833-3065-431e-b7e6-e9914384d65b, api error ResourceInUseException: Consumer None is not in an ACTIVE state

Kinesis doesn't allow deregistering a consumer that is not ready. While this situation is unlikely, the connector should be able to be opened and immediately closed. Testing for that would have prevented this error.

The acceptance tests already test for open - reading / writing - teardown, but not for open - teardown.

@alarbada alarbada added feature New feature or request triage Needs to be triaged labels May 20, 2024
@lovromazgon lovromazgon removed the triage Needs to be triaged label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants