Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Breaking change - conduit commons parameter #109

Closed
wants to merge 4 commits into from
Closed

[WIP] Breaking change - conduit commons parameter #109

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51b1788
use parameter from conduit-commons
lovromazgon Feb 15, 2024
a29f522
remove paramgen
lovromazgon Feb 15, 2024
6bf14d9
gofumpt
lovromazgon Feb 15, 2024
b639378
organize imports
lovromazgon Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions acceptance_testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (
"testing"
"time"

"github.com/conduitio/conduit-commons/config"
"github.com/jpillora/backoff"
"github.com/matryer/is"
"go.uber.org/goleak"
Expand Down Expand Up @@ -565,9 +566,9 @@ func (a acceptanceTest) TestSource_Configure_RequiredParams(t *testing.T) {
origCfg := a.driver.SourceConfig(t)

for name, p := range srcSpec.Parameters() {
isRequired := p.Required
var isRequired bool
for _, v := range p.Validations {
if _, ok := v.(ValidationRequired); ok {
if _, ok := v.(config.ValidationRequired); ok {
isRequired = true
break
}
Expand Down Expand Up @@ -799,9 +800,9 @@ func (a acceptanceTest) TestDestination_Configure_RequiredParams(t *testing.T) {
origCfg := a.driver.DestinationConfig(t)

for name, p := range destSpec.Parameters() {
isRequired := p.Required
var isRequired bool
for _, v := range p.Validations {
if _, ok := v.(ValidationRequired); ok {
if _, ok := v.(config.ValidationRequired); ok {
isRequired = true
break
}
Expand Down
170 changes: 0 additions & 170 deletions cmd/paramgen/README.md
View file
Open in desktop

This file was deleted.

Loading