Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector.yaml: validate Git tag and connector version #59

Closed
Tracked by #63
hariso opened this issue Nov 15, 2024 · 1 comment · Fixed by #60
Closed
Tracked by #63

connector.yaml: validate Git tag and connector version #59

hariso opened this issue Nov 15, 2024 · 1 comment · Fixed by #60
Assignees

Comments

@hariso
Copy link
Contributor

hariso commented Nov 15, 2024

Part of ConduitIO/conduit#1523.

Making sure that a pushed tag is the same as specification.version from connector.yaml is part of Version Handling explained in ConduitIO/conduit#1522.

Feature description

4. Version handling

We need to add some safeguards to ensure the connector.version field in connector.yml contains the correct version and matches the git tag. The idea is to use two GitHub actions to automate this:

  • A GitHub action is triggered BEFORE release, checks if the pushed tag matches the tag in connector.yml. If it does NOT match, it deletes the tag and fails the action, preventing the release.
    ...
    The result is a connector.yml that contains the correct latest released version which matches the last git tag.
@hariso hariso self-assigned this Nov 28, 2024
@hariso hariso transferred this issue from ConduitIO/conduit-connector-sdk Dec 2, 2024
@hariso hariso changed the title specgen: handle connector versioning connector.yaml: handle connector versioning Dec 3, 2024
@hariso hariso changed the title connector.yaml: handle connector versioning connector.yaml: validate Git tag and connector version Dec 3, 2024
@hariso hariso moved this from In Progress to In Review in Conduit Main Dec 3, 2024
@hariso
Copy link
Contributor Author

hariso commented Dec 9, 2024

Fixed by #60.

@hariso hariso closed this as completed Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Conduit Main Dec 9, 2024
@hariso hariso mentioned this issue Dec 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant