Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade conduit-commons and other deps #25

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Upgrade conduit-commons and other deps #25

merged 3 commits into from
Mar 7, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 7, 2024

Description

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner March 7, 2024 11:08
raulb
raulb reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso looks like something broke https://github.com/ConduitIO/conduit-processor-sdk/actions/runs/8187129513/job/22386959045?pr=25#step:4:244

@hariso
Copy link
Contributor Author

hariso commented Mar 7, 2024

@raulb yeah, unfortunately the latest release of Buf CLI and the latest version of google.golang.org/protobuf don't play well together. I've changed this PR to use a slightly older version of conduit-commons that doesn't use the latest version of protobuf.

@lovromazgon lovromazgon merged commit cf2a761 into main Mar 7, 2024
5 checks passed
@lovromazgon lovromazgon deleted the haris/upgrade-deps branch March 7, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb left review comments

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariso @raulb @lovromazgon