Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol unvailable: suggest for replacement #8

Open
hacktar opened this issue Feb 24, 2016 · 5 comments
Open

Symbol unvailable: suggest for replacement #8

hacktar opened this issue Feb 24, 2016 · 5 comments

Comments

@hacktar
Copy link

hacktar commented Feb 24, 2016

We are using hooked provider and lightwallet libs for our mobile wallet LETH (https://github.com/inzhoop-co/LETH) and we find some issues using Symbol on android devices.

In hooked-web3-provider.js 
row 49: ... requests[Symbol.iterator]() ...

Symbol is unvailable for more devices so we suggest a fix with a replacement using forEach, like this :

requests.forEach(function(request) {
   if (request.method == "eth_sendTransaction") {
       throw new Error("HookedWeb3Provider does not support synchronous transactions. Please provide a callback.");
}

Look at our version on github for complete file:
https://github.com/inzhoop-co/LETH/blob/master/www/lib/thirdparty/hooked-web3-provider.js

Great work!

@sponnet
Copy link

sponnet commented Mar 6, 2016

Also seems to fail on safari browsers ( tested on v 8.0.8 )

@sponnet
Copy link

sponnet commented Mar 6, 2016

And I also tested this modification - it also works on safari

sponnet added a commit to A-StadLabs/poezenclub that referenced this issue Mar 6, 2016
@danielnovy
Copy link

Just faced the same problem using Firefox for Linux and Safari.

@sponnet
Copy link

sponnet commented Apr 24, 2016

Note that we solved this problem using the link above... Please Let us know if this also solves yours. Thx

@danielnovy
Copy link

Thanks @sponnet, it does work for my cases as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants