Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor global icon import out of library #436

Open
MikeLockz opened this issue Dec 30, 2019 · 0 comments · May be fixed by #437
Open

Refactor global icon import out of library #436

MikeLockz opened this issue Dec 30, 2019 · 0 comments · May be fixed by #437
Assignees
@MikeLockz

Comments

@MikeLockz
Copy link
Contributor

MikeLockz commented Dec 30, 2019 •
edited
Loading

There should not be a dependence on importing all icons into rimble-ui. The current Icon component imports import * as RimbleIcons from @rimble/icons all icons or import Icon from "../Icon" . This creates a large library bundle size that does not tree-shake properly.

Components that utilize a global import that will need refactoring:

  • Icon
  • ToastMessage
  • Button

Refactor components to only import single icons as needed:

  • EthAddress
  • FileInput
@MikeLockz MikeLockz self-assigned this Dec 30, 2019
@MikeLockz MikeLockz linked a pull request Dec 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeLockz MikeLockz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove global icon imports ConsenSysMesh/rimble-ui
1 participant
@MikeLockz