Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate CI failing for external contributors #492

Open
4 of 6 tasks
kyzooghost opened this issue Jan 6, 2025 · 0 comments
Open
4 of 6 tasks

Investigate CI failing for external contributors #492

kyzooghost opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request P3: Low Issue priority: low

Comments

@kyzooghost
Copy link
Contributor

kyzooghost commented Jan 6, 2025

Description

Currently the CI for linea-monorepo fails to run for PRs made by external contributors

This is because Github Actions will not pass secrets when the workflow is triggered from a forked repository. As this is a security design choice by Github and there are no apparent quick risk-free fixes here, we will need to consider alternative CI design and security tradeoffs.

Motivation

See description

Tasks

  • Investigate methods to enable CI to pass for external contributors

Acceptance criteria

  • Design document +/- discussion

Risks

  • Security risks introduced by any methods we are proposing

Remember to

  • Add the documentation label in case there is an impact on the documentation
  • Add priority and team labels
  • Add Task for updating the Runbook or adding/updating existing metrics and alerts.
@kyzooghost kyzooghost added P3: Low Issue priority: low TechDebt Technical Debt labels Jan 6, 2025
@kyzooghost kyzooghost self-assigned this Jan 6, 2025
@kyzooghost kyzooghost added enhancement New feature or request and removed TechDebt Technical Debt labels Jan 6, 2025
@kyzooghost kyzooghost changed the title CI failing for external contributors Investigate CI failing for external contributors Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3: Low Issue priority: low
Projects
None yet
Development

No branches or pull requests

1 participant