Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates required to a property and the example provided in EnergyPlanSolarFeedInTariff schema #456

Closed
NeelVerma opened this issue Jan 10, 2022 · 3 comments
Labels

Comments

@NeelVerma
Copy link

NeelVerma commented Jan 10, 2022

Description

Update required to a property and the provided example in EnergyPlanSolarFeedInTariff schema.

Area Affected

Change Proposed

  • Please update the "Type", "Description" and associated example of the property "timeVaryingTariffs" to indicate that it is an array.
  • Please update the "tariffUType" in the given example to "timevaryingTariffs" as "timevaryingTariffs" is conditional, it is mandatory when the "tariffUType" is set to "timeVaryingTariffs".
  • Please refer to the following link with detailed information from @joe-parkin-aer from Australian Energy Regulator (AER) about this object previously, another suggestion would be to use a combined example to cover this scenario as mentioned here --> [https://github.com/Decision Proposal 190 - Candidate Generic Tariff End Points standards#190#issuecomment-927507635]
  • Please refer to the attached image with the requested changes highlighted:

CDS_Change Request for EnergyPlanSolarFeedInTariff_Updates_NV

@NeelVerma NeelVerma changed the title [Descriptive Issue Title] Update required to a property and the provided example in EnergyPlanSolarFeedInTariff schema Jan 10, 2022
@NeelVerma NeelVerma changed the title Update required to a property and the provided example in EnergyPlanSolarFeedInTariff schema Updates required to a property and the provided example in EnergyPlanSolarFeedInTariff schema Jan 10, 2022
@NeelVerma NeelVerma changed the title Updates required to a property and the provided example in EnergyPlanSolarFeedInTariff schema Updates required to a property and the example provided in EnergyPlanSolarFeedInTariff schema Jan 10, 2022
@mattyp
Copy link

mattyp commented Jan 29, 2024

+1

This is duplicate of #624 (comment)

@nils-work
Copy link
Member

Hi @NeelVerma
Re: your proposed changes:

Please update the "Type", "Description" and associated example of the property "timeVaryingTariffs" to indicate that it is an array.

This was resolved in Standards version 1.30.0 when EnergyPlanSolarFeedInTariffV3 was introduced.

Please update the "tariffUType" in the given example to "timevaryingTariffs" as "timevaryingTariffs" is conditional, it is mandatory when the "tariffUType" is set to "timeVaryingTariffs".

The Non-normative example demonstrates the full structure of all properties in the schema.
As both the singleTariff and timeVaryingTariffs fields are conditionally mandatory based on the value of tariffUType, singleTariff is a valid value and simply demonstrates the first enum option that references that structure.

Please comment if I've misunderstood your concerns or if this issue can now be closed.

I have also noted that there appears to be a copy/paste error in the Description of the tariffUType field which can be addressed in Maintenance Iteration 20.

@nils-work
Copy link
Member

If there are no further comments, this issue will be closed on 30 August 2024.

@github-project-automation github-project-automation bot moved this from Full Backlog to Done in Data Standards Maintenance Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants