Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OAS Validator/Generator #414

Closed
nils-work opened this issue Jul 25, 2024 · 1 comment
Closed

Update OAS Validator/Generator #414

nils-work opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nils-work
Copy link
Member

Description
The current OAS generate script (swagger-gen\oas_generate.sh) doesn't clearly specify the OpenAPI Generator jar file version used for validating and generating the OAS output in the Standards build process.

The version details should be updated and aligned.

Validate OAS version

- VALID_OAS=$(java -jar $OAS_CODEGEN/openapi-generator-cli.jar validate -i $INPUT_SWAGGER)
+ VALID_OAS=$(java -jar $OAS_CODEGEN/openapi-generator-cli-6.6.0.jar validate -i $INPUT_SWAGGER)

Key change above is:

- openapi-generator-cli.jar
+ openapi-generator-cli-6.6.0.jar

Generate OAS version

- java -jar $OAS_CODEGEN/openapi-generator-cli-5.2.1.jar generate -i $INPUT_SWAGGER -g $OUTPUT_FORMAT -o $SWAGGER_CODEGEN_OUTPUT > $SWAGGER_CODEGEN_OUTPUT/log.txt 2>&1
+ java -jar $OAS_CODEGEN/openapi-generator-cli-6.6.0.jar generate -i $INPUT_SWAGGER -g $OUTPUT_FORMAT -o $SWAGGER_CODEGEN_OUTPUT > $SWAGGER_CODEGEN_OUTPUT/log.txt 2>&1

Key change above is:

- openapi-generator-cli-5.2.1.jar
+ openapi-generator-cli-6.6.0.jar

The newer version provides improved schema validation detail and on generation improves output formatting with clearer nested schema references.

@nils-work nils-work added the enhancement New feature or request label Jul 25, 2024
@nils-work nils-work added this to the v1.32.0 milestone Jul 25, 2024
@nils-work nils-work self-assigned this Aug 29, 2024
@nils-work
Copy link
Member Author

Validation only was updated to the newer version in Standards 1.32.0.

#445 - Update the OAS Generator jar version will consider the change to the generate version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant