Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving benchmarks to avalanche #7

Open
AntonioCarta opened this issue Apr 14, 2022 · 6 comments
Open

Moving benchmarks to avalanche #7

AntonioCarta opened this issue Apr 14, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@AntonioCarta
Copy link
Contributor

I think Avalanche is ready to integrate the CRL benchmarks.

@NickLucche do you agree with moving the benchmarks in avalanche? Once they are in the main repository, they would be considered "stable" and possibly receive more attention. There are a lot of people using Avalanche just for the benchmarks that may not know about avalanche-rl.

@AntonioCarta AntonioCarta added the enhancement New feature or request label Apr 14, 2022
@NickLucche
Copy link
Member

Good job with new API, it looks like a much simpler abstraction over the core concept of streams, I'll try to create a PR in avalanche asap integrating the work I did on CRL benchmarks.

@NickLucche
Copy link
Member

Done here ContinualAI/avalanche#984

@vlomonaco
Copy link
Member

Shouldn't we remove them now from Avalanche-RL?

@AntonioCarta
Copy link
Contributor Author

I agree, we shouldn't duplicate features. avalanche-rl should use avalanche benchmarks now.

@NickLucche
Copy link
Member

Yep, in order to do so we need to add this #8 tho, currently we can't just import the latest avalanche version due to the major changes in its structure since I last backported it

@NickLucche
Copy link
Member

Re-opening with a possible solution implemented here https://github.com/ContinualAI/avalanche-rl/tree/new-avalanche-version.
It involves a workaround to keep the old avalanche BaseStrategy around before fully switching to the Templates model.
It uses the newly implemented benchmarks in avalanche (up to date with the master branch) and BasePlugin/BaseLogger.

@NickLucche NickLucche reopened this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants