Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Different Buffers Are Used On LaMAML Strategy #84

Open
AlboAlby00 opened this issue Nov 25, 2024 · 1 comment
Open

Two Different Buffers Are Used On LaMAML Strategy #84

AlboAlby00 opened this issue Nov 25, 2024 · 1 comment

Comments

@AlboAlby00
Copy link

I think that there is a mistake in the lamaml.py files.
The LaMAML Strategy is still using a ReplayPlugin, but after switching from lamaml to lamaml_v2, the buffer should already be handled internally by the LaMAML strategy, and the plugin is adding an additional buffer that is not supposed to exist.
I think the ReplayPlugin should be removed.
If someone can confirm this is the case, I can quickly fix the problem.

@AlboAlby00
Copy link
Author

AlboAlby00 commented Nov 25, 2024

Removing the ReplayPlugin improved the final accuracy from 0.66 to 0.695 on the SplitCifar100 benchmark. I am 90% confident that this is actually a bug. I created a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant