You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think that there is a mistake in the lamaml.py files.
The LaMAML Strategy is still using a ReplayPlugin, but after switching from lamaml to lamaml_v2, the buffer should already be handled internally by the LaMAML strategy, and the plugin is adding an additional buffer that is not supposed to exist.
I think the ReplayPlugin should be removed.
If someone can confirm this is the case, I can quickly fix the problem.
The text was updated successfully, but these errors were encountered:
Removing the ReplayPlugin improved the final accuracy from 0.66 to 0.695 on the SplitCifar100 benchmark. I am 90% confident that this is actually a bug. I created a PR to fix this.
I think that there is a mistake in the lamaml.py files.
The LaMAML Strategy is still using a ReplayPlugin, but after switching from lamaml to lamaml_v2, the buffer should already be handled internally by the LaMAML strategy, and the plugin is adding an additional buffer that is not supposed to exist.
I think the ReplayPlugin should be removed.
If someone can confirm this is the case, I can quickly fix the problem.
The text was updated successfully, but these errors were encountered: