-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Background Play #1
Comments
Before Background Play, music should be played inside app . I guess it's not there . Correct me sir if I am wrong. not_playing.mp4 |
@samimshoaib01 I have updated the repo. Pull the latest commit. |
Sir I checked, Background play is already implemented I guess. |
@samimshoaib01 ok your task is to create a settings page where a person can toggle background play on and off. I'll be giving you an extra day as well. Someone else had implemented this before apparently, sorry for the inconvenience. |
sue sir i will try to implement it |
Sir , i implemented this , shall I request for this again ?? |
@samimshoaib01 yeah request for it again |
Sir for now it says , Assignment Request for Issue #1 of Music-Player cannot be made by you currently. Further i want to ask that if i am allowed to add functionality in app according to me or not. |
@samimshoaib01 If you want to add a new feature/point out a bug you can create a new issue yourself, or tell me and I will create one. or if you implement it with the current issue I will award bonus points as per your task done. Also take a look at #5 if you have the time. |
@samimshoaib01 yeah request for it again. |
@samimshoaib01 status? |
Good evening sir, So i tried to fix . I have developed the ui and many more functionality upon which now issue can be assigned and will be easy to work for everyone. Here are some glimpses of it : So sir, kindly create New issues regarding this. I hope I will get bonus points for these |
@samimshoaib01 yes... you will get bonus points for the stuff you have done. But first open a PR. |
Enable toggling of background play via the settings.
The text was updated successfully, but these errors were encountered: