Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Background Play #1

Closed
Pra-San opened this issue Oct 7, 2024 · 14 comments
Closed

Toggle Background Play #1

Pra-San opened this issue Oct 7, 2024 · 14 comments
Assignees
Labels
enhancement New feature or request hacktoberfest medium level Pra-San mentor wontfix This will not be worked on

Comments

@Pra-San
Copy link
Member

Pra-San commented Oct 7, 2024

Enable toggling of background play via the settings.

@Pra-San Pra-San added enhancement New feature or request hard level medium level and removed hard level labels Oct 7, 2024
@samimshoaib01
Copy link

Before Background Play, music should be played inside app . I guess it's not there . Correct me sir if I am wrong.

not_playing.mp4

@Pra-San
Copy link
Member Author

Pra-San commented Oct 17, 2024

@samimshoaib01 I have updated the repo. Pull the latest commit.

@Pra-San Pra-San added bonus bonus points available and removed bonus bonus points available labels Oct 17, 2024
@samimshoaib01
Copy link

samimshoaib01 commented Oct 17, 2024

Sir I checked, Background play is already implemented I guess.

@Pra-San
Copy link
Member Author

Pra-San commented Oct 18, 2024

@samimshoaib01 ok your task is to create a settings page where a person can toggle background play on and off. I'll be giving you an extra day as well.

Someone else had implemented this before apparently, sorry for the inconvenience.

@samimshoaib01
Copy link

sue sir i will try to implement it

@samimshoaib01
Copy link

Sir , i implemented this , shall I request for this again ??

@samimshoaib01
Copy link

Screenshot_2024-10-23-08-00-44-134_com.example.musicplayer.jpg

Screenshot_2024-10-23-08-00-50-988_com.example.musicplayer.jpg

Instead of new page I have added a switch to enable and disable background music play.

@Pra-San
Copy link
Member Author

Pra-San commented Oct 23, 2024

@samimshoaib01 yeah request for it again

@Pra-San Pra-San changed the title Enable Background Play Toggle Background Play Oct 23, 2024
@samimshoaib01
Copy link

samimshoaib01 commented Oct 23, 2024

Sir for now it says , Assignment Request for Issue #1 of Music-Player cannot be made by you currently.

Further i want to ask that if i am allowed to add functionality in app according to me or not.

@Pra-San
Copy link
Member Author

Pra-San commented Oct 23, 2024

@samimshoaib01 If you want to add a new feature/point out a bug you can create a new issue yourself, or tell me and I will create one. or if you implement it with the current issue I will award bonus points as per your task done. Also take a look at #5 if you have the time.

@Pra-San
Copy link
Member Author

Pra-San commented Oct 23, 2024

@samimshoaib01 yeah request for it again.

@Pra-San
Copy link
Member Author

Pra-San commented Oct 24, 2024

@samimshoaib01 status?

@samimshoaib01
Copy link

samimshoaib01 commented Oct 24, 2024

Good evening sir,
I tried to implement issues, but there were too much error regarding build.gradle , SDK version etc when trying to take permission , view binding , foreground services .

So i tried to fix . I have developed the ui and many more functionality upon which now issue can be assigned and will be easy to work for everyone.

Here are some glimpses of it :

Screenshot_2024-10-24-22-40-52-318_com.example.musicplayer.jpg

Screenshot_2024-10-24-22-40-47-135_com.example.musicplayer.jpg

Screenshot_2024-10-24-22-41-24-952_com.example.musicplayer.jpg

So sir, kindly create New issues regarding this.
It have many functionalities like
1)Glide android library
2)Can work with latest Android
3) Navigation drawer

I hope I will get bonus points for these

@Pra-San
Copy link
Member Author

Pra-San commented Oct 25, 2024

@samimshoaib01 yes... you will get bonus points for the stuff you have done. But first open a PR.

@Pra-San Pra-San closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@Pra-San Pra-San added the wontfix This will not be worked on label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest medium level Pra-San mentor wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants