From 0823f0dce5fc2c87655f3a67196e24c3cf797185 Mon Sep 17 00:00:00 2001 From: DarkThor76 <39576038+DarkThor76@users.noreply.github.com> Date: Sun, 6 Oct 2024 23:19:12 -0400 Subject: [PATCH 1/3] Update TimerBar.js "<0%" makes no sense. Should be offset by 0.01 (1%). Honestly, probably do not need the call to getChanceFinal() in the output either but I'll leave that up to someone more authoritative. --- src/Disp/InfoBars/TimerBar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Disp/InfoBars/TimerBar.js b/src/Disp/InfoBars/TimerBar.js index 3c5d6fe1..7aa72462 100644 --- a/src/Disp/InfoBars/TimerBar.js +++ b/src/Disp/InfoBars/TimerBar.js @@ -133,7 +133,7 @@ export function UpdateTimerBar() { updateChanceTotal(chanceToSpawn); l('CMTimerBarGCTime').textContent = `${Math.ceil( (Game.shimmerTypes.golden.maxTime - Game.shimmerTypes.golden.time) / Game.fps, - )} ${getChanceFinal() < 0.01 ? '<' : ''}${getChanceFinal().toLocaleString('en', { + )} ${getChanceFinal() < 0.01 ? '<' : ''}${(getChanceFinal() + 0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). style: 'percent', })}`; numberOfTimers += 1; From f23ccb00ede469ff1e78b7536ef1c79f37afbbc5 Mon Sep 17 00:00:00 2001 From: DarkThor76 <39576038+DarkThor76@users.noreply.github.com> Date: Fri, 11 Oct 2024 15:34:01 -0400 Subject: [PATCH 2/3] Update TimerBar.js Found another occurence of the previous formatting error. --- src/Disp/InfoBars/TimerBar.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Disp/InfoBars/TimerBar.js b/src/Disp/InfoBars/TimerBar.js index 7aa72462..ec099292 100644 --- a/src/Disp/InfoBars/TimerBar.js +++ b/src/Disp/InfoBars/TimerBar.js @@ -133,7 +133,7 @@ export function UpdateTimerBar() { updateChanceTotal(chanceToSpawn); l('CMTimerBarGCTime').textContent = `${Math.ceil( (Game.shimmerTypes.golden.maxTime - Game.shimmerTypes.golden.time) / Game.fps, - )} ${getChanceFinal() < 0.01 ? '<' : ''}${(getChanceFinal() + 0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). + )} ${getChanceFinal() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). style: 'percent', })}`; numberOfTimers += 1; @@ -177,7 +177,7 @@ export function UpdateTimerBar() { updateChanceTotalDeer(chanceToSpawn); l('CMTimerBarRenTime').textContent = `${Math.ceil( (Game.shimmerTypes.reindeer.maxTime - Game.shimmerTypes.reindeer.time) / Game.fps, - )} ${getChanceFinalDeer() < 0.01 ? '<' : ''}${getChanceFinalDeer().toLocaleString('en', { + )} ${getChanceFinalDeer() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). style: 'percent', })}`; numberOfTimers += 1; From b2ca44f9bce0a7331ecff9d838969653c0f9e01b Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 11 Oct 2024 19:38:31 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/Disp/InfoBars/TimerBar.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Disp/InfoBars/TimerBar.js b/src/Disp/InfoBars/TimerBar.js index ec099292..39ba3942 100644 --- a/src/Disp/InfoBars/TimerBar.js +++ b/src/Disp/InfoBars/TimerBar.js @@ -133,7 +133,8 @@ export function UpdateTimerBar() { updateChanceTotal(chanceToSpawn); l('CMTimerBarGCTime').textContent = `${Math.ceil( (Game.shimmerTypes.golden.maxTime - Game.shimmerTypes.golden.time) / Game.fps, - )} ${getChanceFinal() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). + )} ${getChanceFinal() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { + // "<0%" makes no sense. Should be offset by 0.01 (1%). style: 'percent', })}`; numberOfTimers += 1; @@ -177,7 +178,8 @@ export function UpdateTimerBar() { updateChanceTotalDeer(chanceToSpawn); l('CMTimerBarRenTime').textContent = `${Math.ceil( (Game.shimmerTypes.reindeer.maxTime - Game.shimmerTypes.reindeer.time) / Game.fps, - )} ${getChanceFinalDeer() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { // "<0%" makes no sense. Should be offset by 0.01 (1%). + )} ${getChanceFinalDeer() < 0.01 ? '<' : ''}${(0.01).toLocaleString('en', { + // "<0%" makes no sense. Should be offset by 0.01 (1%). style: 'percent', })}`; numberOfTimers += 1;