<0% formatting #1192
Open
<0% formatting #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"<0%" makes no sense. Should be offset by 0.01 (1%). Honestly, probably do not need the call to getChanceFinal() in the output either but I'll leave that up to someone more authoritative.
Found another occurence of the previous formatting error.
for more information, see https://pre-commit.ci
|
@DarkThor76 Could you also update the generated files? Both |
|
@DanielNoord sorry, I can't. |
|
I won't be able to merge this without doing so and won't be able to do this myself in the forseeable future. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be rather self-explanatory. Attempting to prevent the situation where "<0%" is shown since less than 0 percent should not be possible. There was also no reason to call getChanceFinal() or getChanceFinalDeer() in the response since the if condition already determined it was less than 1% so it should be okay to simply write "<1%".