Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

german umlauts - broken format #30

Closed
bukenbp8 opened this issue Feb 8, 2024 · 5 comments · Fixed by #31
Closed

german umlauts - broken format #30

bukenbp8 opened this issue Feb 8, 2024 · 5 comments · Fixed by #31

Comments

@bukenbp8
Copy link

bukenbp8 commented Feb 8, 2024

Hi I have following problem with using the chat with german umlauts (e.g. ä, ö, ü)

Example prompt: generate me a sentence with a lot of german umlauts.

NVIM v0.9.5
Distro is Arch Linux

Screenshot:
screenshot-20240208-103053

The issue is that sometimes they are replaced like ü with and sometimes they are displayed but the following character is placed in a completely different position.

I use Lazyvim but i tried also with Astronvim both with the same problem.

@gptlang
Copy link
Member

gptlang commented Feb 8, 2024

This is a known issue for multi-byte characters. Set branch to pr-chinese-fix as a temporary fix. It makes the output a bit slower which is why it hasn't been merged yet. Trying to find better ways of detecting when bytes are incomplete.

@bukenbp8
Copy link
Author

bukenbp8 commented Feb 8, 2024

Thank you for your fast reply! I switched the branch to pr-chinese-fix but i encountered this error whenever i want to prompt something:

Encountered SyntaxError loading plugin at /home/foo/.local/share/nvim/lazy/CopilotChat.nvim/rplugin/python3/copilot-plugin.py: unterminated string literal (detected at line 206) (chat_handler.py, line 206) Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/pynvim/plugin/host.py", line 187, in _load module = _handle_import(directory, name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/pynvim/plugin/host.py", line 40, in _handle_import return importlib.import_module(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "<frozen importlib._bootstrap>", line 1204, in _gcd_import File "<frozen importlib._bootstrap>", line 1176, in _find_and_load File "/home/foo/.local/share/nvim/lazy/CopilotChat.nvim/rplugin/python3/handlers/chat_handler.py", line 206 f"Please visit {req['verification_uri'] ^ SyntaxError: unterminated string literal (detected at line 206)

i am not very familiar with python i guess its the string interpolation? Don't know if i have to delete something? Sorry to bother you with this. I really appreciate your work

@gptlang
Copy link
Member

gptlang commented Feb 8, 2024

Sorry about that. Fixed it. Something weird with my LSP formatter

@bukenbp8
Copy link
Author

bukenbp8 commented Feb 8, 2024

Thank you very much! Its a bit slow but usable. Looking forward to see this in the main branch.

@gptlang gptlang linked a pull request Feb 8, 2024 that will close this issue
@gptlang
Copy link
Member

gptlang commented Feb 8, 2024

It has now been fully fixed in main without the slowness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants