Optimise parsing by removing excessive copying. #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation the copy-on-write causes excessive copying when building the box tree.
I've inlined the
merge
function intotransformToBoxTree
and used astorage
variable to avoid it being passed around and copied.In my tests this results in a ~30x speedup and makes all the difference in my use case.
Also IMO the code is a little clearer now as it shows the recursive nature of the algorithm in one function.