Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Do you have a library version of crypto-candlesticks? #369

Open
asehmi opened this issue Sep 22, 2022 · 4 comments
Open

Question: Do you have a library version of crypto-candlesticks? #369

asehmi opened this issue Sep 22, 2022 · 4 comments

Comments

@asehmi
Copy link

asehmi commented Sep 22, 2022

Hi,

Just wondering if you have an official library (non-interactive CLI) version of this application? I'd like to incorporate it in a Streamlit application. I have done some experiments a year ago and it is possible.

If I do this again (make it a library) using the latest version (so I can use it in Streamlit), and submit it back to you, would that be acceptable?

Thanks,
Arvindra

@Corfucinas
Copy link
Owner

Corfucinas commented Sep 22, 2022

Hey @asehmi that would be fantastic, I will gladly accept the PR.

I've wanted to extend some of the functionalities, but unfortunately, I do not have the time on my hands right now; feel free to submit any improvements, thanks!

@asehmi
Copy link
Author

asehmi commented Sep 22, 2022

Excellent... I have forked the repo and made a folder lib-crypto-candlesticks alongside crypto-candlesticks. I'm using a branch of the same name. I'll try to put a sample Streamlit app in the examples folder. PR pending.

Many thanks,
Arvindra

@asehmi
Copy link
Author

asehmi commented Oct 3, 2022

Just to let you know I finished this work last week and am busy building the Streamlit app. I've had to put in some exception handling (replacing the sys exits) and introduced a natural key in the db schema so that values can be replaced rather than added, which is helpful when building a full data snapshot for a crypto coin. The Streamlit app makes it easy to build datasets and visualize the candles. I also adjusted the default start/end time functions as crypto can be traded 24/7/365, unlike equities which are 8/5/220. More news soon. Send me an email/message with your email so we can have a zoom call?

@Corfucinas
Copy link
Owner

Hey! Currently on holiday, let's talk next week. Use my email to send a meeting invitation: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants