Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are these assignments incorrect? #378

Open
asehmi opened this issue Oct 11, 2022 · 1 comment
Open

Are these assignments incorrect? #378

asehmi opened this issue Oct 11, 2022 · 1 comment

Comments

@asehmi
Copy link

asehmi commented Oct 11, 2022

'Open': candle[2],
'Close': candle[1],

Hi - Just wondering why Open and Close values are assigned as indexes 2 and 1 respectively, and not 1 and 2?

The Bitfinex API docs shows that it should be 1, 2.

@Corfucinas
Copy link
Owner

Corfucinas commented Oct 12, 2022

Good question, I coded this using old documentation from Bitfinex (they have replaced it) two years ago. There's the possibility that I got it wrong or that they have updated the index with the new API(?). In any case, I'll replace the slices with a Dataclass in the next release, using tuple slices it's bad anyways.

I'll leave this open as a reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants