Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor third script and move inside package #123

Open
pmayd opened this issue Jan 3, 2024 · 0 comments
Open

Refactor third script and move inside package #123

pmayd opened this issue Jan 3, 2024 · 0 comments

Comments

@pmayd
Copy link
Collaborator

pmayd commented Jan 3, 2024

I guess this is not really related to the PR so maybe we should address it separately, but generally I would suggest to move functionality into the package itself and keep the script shorter, similar to how script 1 and 2 changed. This would also make statements about test coverage inside the package more meaningful wrt. to the overall project. So the situation that tests pass, coverage is good, and scripts still fail is less likely.

Ursprünglich gepostet von @KonradUdoHannes in #121 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant