Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on missing #[custom(msg=...)] or ExecC on trait #162

Closed
Tracked by #157
, #296
...
hashedone opened this issue Jun 7, 2023 · 2 comments · Fixed by #323
Closed
Tracked by #157
, #296
...

Warn on missing #[custom(msg=...)] or ExecC on trait #162

hashedone opened this issue Jun 7, 2023 · 2 comments · Fixed by #323
Assignees
@kulikthebird
Labels
part Part of a bigger issue
Milestone
1.0.0

Comments

@hashedone
Copy link
Collaborator

hashedone commented Jun 7, 2023 •
edited
Loading

We want a warning message on interfaces not allowing for custom message specification. The #[custom(msg=cosmwasm_std::Empty)] should explicitly shut down this warning.
@hashedone hashedone mentioned this issue Jun 7, 2023
Closed
5 tasks
@hashedone hashedone added the part Part of a bigger issue label Jun 9, 2023
@jawoznia jawoznia mentioned this issue Jun 15, 2023
Closed
@jawoznia
Copy link
Collaborator

Since emit_warning! works only on nightly and cause our test to some weird fail we will postpone this task and remove from #157 requirements

@jawoznia jawoznia mentioned this issue Jan 25, 2024
Closed
3 tasks
@hashedone hashedone added this to the 1.0.0 milestone Feb 20, 2024
@hashedone hashedone changed the title Warn on missing #[custom(...)] of ExecC on trait Warn on missing #[custom(...)] or ExecC on trait Feb 20, 2024
@hashedone hashedone changed the title Warn on missing #[custom(...)] or ExecC on trait Warn on missing #[custom(msg=...)] or ExecC on trait Feb 20, 2024
@hashedone
Copy link
Collaborator Author

Same for QueryC + #[custom(query=...)]

@kulikthebird kulikthebird self-assigned this Feb 27, 2024
@kulikthebird kulikthebird linked a pull request Mar 11, 2024 that will close this issue
feat: Handle missing explicite custom types #323
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kulikthebird kulikthebird

Labels
part Part of a bigger issue
Projects
None yet
Milestone
1.0.0
3 participants
@hashedone @kulikthebird @jawoznia