Diff reduction: run linter autofixes #1546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the test system works here, but I'll take it. |
* use a constant * use a constant for badAddress
* marshaler to codec * Update tests/e2e/ibc_fees_test.go Co-authored-by: pinosu <[email protected]> * Update tests/e2e/ibc_fees_test.go Co-authored-by: pinosu <[email protected]> * fix a few remaining issues --------- Co-authored-by: pinosu <[email protected]>
Closed
faddat
force-pushed
the
linterautofixes
branch
from
80aaa83
to
fcecbf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter produced much more diff than actually exists.
This PR runs golangci-lint run ./... against the v50 branch, so that earlier PRs I made like:
Don't seem like they contain excessively large chainsets.
It's also meant to keep things easy to review :).
-Jacob