[Do not merge] Reproduction of #1536 #1568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff! Did you check if the fix from #1567 solves the problem? Looking at the diff I doubt we should merge CosmWasm/wasmvm#448. It just makes the API more complex and exposes internals to wasmd that we don't need there for the happy path. |
|
Yes, #1567 makes all tests pass. I agree, it's just information wasmd shouldn't need. |
|
Closing this, as the fix is merged and we won't merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a few assertions to show the problem.
If we want to merge this at some point, we probably want to remove them and create separate tests instead (but that requires some more changes).
Currently uses an unreleased version of wasmvm to get access to the gas data.