-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
capabilities: Use AllCapabilities() instead of manual string capabilities #759
Comments
not possible with it being in app, need to have it be upstream in wasmvm or wasmd types or something |
Hey @Reecepbcups! Where would you need this function in wasmd? Could you send a PR to wasmd? It cannot be in wasmvm because what this list is saying semantically is: "all the capabilities that this backend is providing". Bumping to a newer wasmvm does not mean a capability is added. From 2.0 onwards, wasmvm will accept a list of strings instead of a coma separated list. So we should work towards the |
@webmaster128 Thank you, I have no clue what problems I was having that day but works now on wasmd v0.45! May have just been an editor false positive for an import or something |
Okay, nice. Then we only have to update the comment of |
app/wasm.go (Useful for when we bump to wasmvm 1.3)
https://github.com/CosmWasm/wasmd/blob/6d770a5a9eea3474851413654833425ab8175754/app/wasm.go#L11
Importing app may be bleh, maybe this should be in types there?
The text was updated successfully, but these errors were encountered: