Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capabilities: Use AllCapabilities() instead of manual string capabilities #759

Closed
Reecepbcups opened this issue Jul 18, 2023 · 4 comments
Closed

Comments

@Reecepbcups
Copy link
Contributor

app/wasm.go (Useful for when we bump to wasmvm 1.3)
https://github.com/CosmWasm/wasmd/blob/6d770a5a9eea3474851413654833425ab8175754/app/wasm.go#L11

Importing app may be bleh, maybe this should be in types there?

@Reecepbcups
Copy link
Contributor Author

not possible with it being in app, need to have it be upstream in wasmvm or wasmd types or something

@webmaster128
Copy link
Collaborator

webmaster128 commented Dec 21, 2023

Hey @Reecepbcups!

Where would you need this function in wasmd? Could you send a PR to wasmd? It cannot be in wasmvm because what this list is saying semantically is: "all the capabilities that this backend is providing". Bumping to a newer wasmvm does not mean a capability is added.

From 2.0 onwards, wasmvm will accept a list of strings instead of a coma separated list. So we should work towards the []string type for all new code.

@Reecepbcups
Copy link
Contributor Author

@webmaster128 Thank you, I have no clue what problems I was having that day but works now on wasmd v0.45! May have just been an editor false positive for an import or something

#926

@webmaster128
Copy link
Collaborator

Okay, nice. Then we only have to update the comment of AllCapabilities which is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants