Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does the CMakeList check to ensure you provide a custom HTTPClient callback when building as a static library? #36

Open
Zephilinox opened this issue Jan 25, 2022 · 4 comments

Comments

@Zephilinox
Copy link

I assume there was some issue that caused this check to be added? I'm curious. I would have thought it would work just fine 🤔

@ArtursKadikis
Copy link
Member

Which check specifically do you mean?

@Zephilinox
Copy link
Author

sorry, I should have linked to it directly :) it's this one https://github.com/Countly/countly-sdk-cpp/blob/master/CMakeLists.txt#L16

@ArtursKadikis
Copy link
Member

Hello. I'm not actually sure myself, the original developers are not part of the team anymore. After looking into git blame, it looks like they were added in this PR:
#16

And one of the issues it would fix is this:
#15

@Zephilinox
Copy link
Author

Zephilinox commented Jan 26, 2022

hi :)

Hello. I'm not actually sure myself, the original developers are not part of the team anymore.

aw okay, no worries :)

#16 fixes windows by excluding it from that check, so it wasn't the original reason for the check being added (for non-windows platforms) 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants