Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of 3D data #4

Open
adamrobcarter opened this issue Sep 4, 2024 · 2 comments · May be fixed by #8
Open

Handling of 3D data #4

adamrobcarter opened this issue Sep 4, 2024 · 2 comments · May be fixed by #8

Comments

@adamrobcarter
Copy link
Contributor

This is related to the section of the code that parses our "x, y, t" data

This line:

elif np.shape(array)[1] == 4: # format if X Y Z N

is gonna cause problems, because we also use a format that is rows of "x, y, t, ID" (where ID is a unique integer for each particle in the dataset). I don't think we're using rows of "x, y, z, t" at any point at the moment, so maybe we don't need this 3D detection. Maybe we should formalise our format

@simongravelle
Copy link
Member

We should definitely decide on what formats we are allowing.

In practice, it does not matter so much, as the converter is outside the code anyway. So we could have as many converters as we have file formats.

@simongravelle
Copy link
Member

Ideally, we will need to have all the possible type of trajectory files within the "datasets" repository, so that we have a good overview of what we need to be able to import.

@simongravelle simongravelle linked a pull request Sep 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants