findbugs-exclude.xml

<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter xmlns="https://github.com/spotbugs/filter/3.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
    <Match>
        <!-- We use explicit newline in order to format generated SQL.
         Also, SQL is generated in a safe way. -->
        <Or>
            <Package name="ru.curs.celesta.dbutils.adaptors"/>
            <Package name="ru.curs.celesta.dbutils.adaptors.ddl"/>
        </Or>
        <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE,SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE"/>
    </Match>
    <Match>
        <Class name="ru.curs.celesta.dbutils.h2.AbstractMaterializedViewTrigger"/>
        <Method name="insert"/>
        <Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING"/>
    </Match>
    <Match>
        <!-- Files automatically generated by JAVACC -->
        <Or>
            <Class name="ru.curs.celesta.score.CelestaParser"/>
            <Class name="ru.curs.celesta.score.CelestaParserTokenManager"/>
            <Class name="ru.curs.celesta.score.CelestaParserConstants"/>
            <Class name="ru.curs.celesta.score.TokenMgrError"/>
            <Class name="ru.curs.celesta.score.SimpleCharStream"/>
            <Class name="ru.curs.celesta.score.ParseException"/>


            <Class name="ru.curs.celesta.dbutils.filter.FilterParser"/>
            <Class name="ru.curs.celesta.dbutils.filter.FilterParserTokenManager"/>
            <Class name="ru.curs.celesta.dbutils.filter.FilterParserConstants"/>
            <Class name="ru.curs.celesta.dbutils.filter.TokenMgrError"/>
            <Class name="ru.curs.celesta.dbutils.filter.SimpleCharStream"/>
            <Class name="ru.curs.celesta.dbutils.filter.ParseException"/>
        </Or>
    </Match>
    <Match>
        <!-- These are triggered by getDate()/setDate() on cursors-->
        <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
    </Match>
    <Match>
        <Class name="ru.curs.celesta.CurrentScore"/>
        <Bug pattern="EI_EXPOSE_STATIC_REP2,MS_EXPOSE_REP"/>
    </Match>
    <Match>
        <!-- Boolean column can contain nulls in database -->
        <Class name="ru.curs.celesta.score.BooleanColumn"/>
        <Bug pattern="NP_BOOLEAN_RETURN_NULL"/>
    </Match>

    <Match>
        <!-- Writes are in subclass -->
        <Class name="ru.curs.celesta.dbutils.DbUpdater"/>
        <Method name="updateDb"/>
        <Bug pattern="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
    </Match>

    <Match>
        <!--Equals for all the testcontainers is defined as o == this -->
        <Class name="ru.curs.celesta.test.common.CollatedMSSQLServerContainer"/>
        <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
    </Match>
    
    <Match>
        <!-- A false positive? -->
        <Class name="ru.curs.celesta.test.ContainerUtils"/>
        <Method name="cleanUp"/>
        <Bug pattern="UC_USELESS_VOID_METHOD"/>
    </Match>
    <Match>
        <!-- A hacked-up class to support Firebird in tests -->
        <Class name="ru.curs.celesta.test.common.AdvancedFireBirdContainer"/>
        <Bug pattern="VA_FORMAT_STRING_USES_NEWLINE,ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD,EQ_DOESNT_OVERRIDE_EQUALS"/>
    </Match>
    <Match>
        <!-- This public field is written in a subclass -->
        <Class name="ru.curs.celesta.dbutils.DbUpdater"/>
       <!-- <Method name="updateDb"/>-->
        <Bug pattern="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"/>
    </Match>
    <Match>
        <!-- See
        https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions -->
        <Bug pattern="CT_CONSTRUCTOR_THROW"/>
    </Match>
</FindBugsFilter>