Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Generall precall for unloader #42

Open
blubstar86 opened this issue Aug 26, 2023 · 10 comments
Open

[Feature] Generall precall for unloader #42

blubstar86 opened this issue Aug 26, 2023 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@blubstar86
Copy link

What is the problem this feature/enhancement solves?
When combine is in first headland or in first row of lands (pipe in fruit) he calls the unloader when he made the pocket for him.

Describe the solution you'd like
Combine calls the unloader earlier behind him, so he isnt that far away when the pocket is done.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
image

@blubstar86 blubstar86 added the enhancement New feature or request label Aug 26, 2023
@Tensuko Tensuko changed the title [Feature] Combine call unloader earlier [Feature] Precall unloader when combine creates pocket on first headland Aug 26, 2023
@Tensuko Tensuko changed the title [Feature] Precall unloader when combine creates pocket on first headland [Feature] Precall unloader when combine creates pocket on first headland (or maybe general pocket) Aug 26, 2023
@rohne83
Copy link
Contributor

rohne83 commented Aug 27, 2023

But it should only do this as long as grain cart doesn't have to chase another combine already ;)
There already seems to be some logic for this. With two combines I the overloader started to drive to the leading combine although it hasn't finished with pocket creation yet. Don't know if this was initiated by the other combine and then assignment switched, but the behaviour was there.

@pvaiko
Copy link
Contributor

pvaiko commented Aug 27, 2023

This can get really complex if we have fruit avoidance turned on for the unloader, as it will try to stay on the field. If the combine works on the fist headland, any location that would make sense to 'precall' the unloader to, would still be unharvested and thus, by default the unloader's pathfinding would take forever and then fail, a) because the target is in fruit, b) the combine would be in the way.

Calling the unloader to a point which the combine already harvested may work, but then, we'd really need to check if that makes sense because the pocket could be closer the the unloader's waiting point than this precall location if the combine gets around the field before full.

Not saying it's not possible but would probably be a good topic for a thesis.

@Tensuko
Copy link
Contributor

Tensuko commented Aug 27, 2023

@rohne83 any unloader registered to a combine can't be called to another combine.

@pvaiko I would just make it a bit more times aving only.
So, when the combine starts creating the pocket, call an unloader to the back of the combine reverse course for the pocket.
Wouldn't make it too complicated, but the unloader could be already on the way while creating the pocket. So we know when the combine creates the pocket and where.

@coatsy35
Copy link

That would be really useful. I know you don't want to allow us to alter the precall level (like AD does), but I have the same issue in large fields on the centre runs. Trailer is miles away from the combine. I'm sure @blubstar86 also experiences this if he's on large field maps alot.

@coatsy35
Copy link

This can get really complex if we have fruit avoidance turned on for the unloader, as it will try to stay on the field. If the combine works on the fist headland, any location that would make sense to 'precall' the unloader to, would still be unharvested and thus, by default the unloader's pathfinding would take forever and then fail, a) because the target is in fruit, b) the combine would be in the way.

Calling the unloader to a point which the combine already harvested may work, but then, we'd really need to check if that makes sense because the pocket could be closer the the unloader's waiting point than this precall location if the combine gets around the field before full.

Not saying it's not possible but would probably be a good topic for a thesis.

Could the trailer not periodically move closer to the combine? IRL when I was grain carting, I would move closer to the combine every now and then, so I was not too far away when the precall lights came on showing he was getting full. Is that type of functionality possible @pvaiko ? perhaps every now and then drive to a couple of hundred metres behind the combine?

@pvaiko
Copy link
Contributor

pvaiko commented Aug 27, 2023

Could the trailer not periodically move closer to the combine? IRL when I was grain carting, I would move closer to the combine every now and then, so I was not too far away when the precall lights came on showing he was getting full. Is that type of functionality possible @pvaiko ? perhaps every now and then drive to a couple of hundred metres behind the combine?

Feedback from IRL experience is always very welcome. And sure, that would be possible (everything is possible, most often the question of priorities as devs have a life too...). We could check our fill level forecast on the first headland at least and see if it makes sense to call an unloader to follow us, for which would have to introduce a new state.

What @Tensuko recommended is the easiest, and would help at least a bit.

@coatsy35
Copy link

Could the trailer not periodically move closer to the combine? IRL when I was grain carting, I would move closer to the combine every now and then, so I was not too far away when the precall lights came on showing he was getting full. Is that type of functionality possible @pvaiko ? perhaps every now and then drive to a couple of hundred metres behind the combine?

Feedback from IRL experience is always very welcome. And sure, that would be possible (everything is possible, most often the question of priorities as devs have a life too...). We could check our fill level forecast on the first headland at least and see if it makes sense to call an unloader to follow us, for which would have to introduce a new state.

What @Tensuko recommended is the easiest, and would help at least a bit.

I understand. Spent many years driving combines and performing all arable operations. I sell agricultural machinery these days though. Thank you for all your effort into this mod and the rest of the team. It is appreciated, it's fantastic.

@rohne83
Copy link
Contributor

rohne83 commented Aug 27, 2023

IRL the grain cart will often follow the combines on headland. But ofc you have to take into account that there may be more than one combine, and the others could need unloading before the leading one.

@Tensuko
Copy link
Contributor

Tensuko commented Aug 27, 2023

All this is a reason to not overcomplicate that and rather keep it simple and have a small benefit :)

@blubstar86
Copy link
Author

Ooops, sorry for the big discussion.

Not sure if i understod everything correct above.

Maybe it could work like this:

first headland / first row of lands

  • Combine hits the 80% fill limit (correct the value if its not the right unload-call-fill-value)
  • check if the prediction for 95% would be still in first headland/row of lands
    • if yes -> then call unloader behind combine
    • if no -> dont call unloader and wait till combine switch to second headland

ofc dont make it too complex, if it would take to much time for just a tiny benefit

@Tensuko Tensuko changed the title [Feature] Precall unloader when combine creates pocket on first headland (or maybe general pocket) [Feature] Generall precall for unloader Oct 4, 2024
@Tensuko Tensuko transferred this issue from Courseplay/Courseplay_FS22 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants