Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Ideas #277

Open
2 tasks
DanielHabenicht opened this issue Oct 29, 2020 · 5 comments
Open
2 tasks

Refactoring Ideas #277

DanielHabenicht opened this issue Oct 29, 2020 · 5 comments
Labels
could have Small improvements that are nice to have but not necessary enhancement New feature or request

Comments

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Oct 29, 2020

  • use project root-relative paths (src/component/name instead of ../../src/component/name)
  • use scss or css files instead of javascript styles

Please add yours as well.

@DanielHabenicht DanielHabenicht added enhancement New feature or request triage Lets talk about this before doing it! labels Oct 29, 2020
@kommander
Copy link
Collaborator

with root relative paths, code completion won't work correctly. I only had bad experiences with that kind of style nonsense. And I'd rather get rid of the CSS file completely than dragging in an SCSS transpiler. So no to both of the items from me, sorry.

@DanielHabenicht
Copy link
Collaborator Author

I am using it with my angular project and its just a typescript setting which hasn't failed me till now.

I really find it cumbersome to convert css to js and not being able to debug where the css style is coming from.

@kommander
Copy link
Collaborator

React dev tools show where the style is coming from:

Screenshot 2020-10-29 at 12 10 06

As for root relative paths... maybe worth a try. I can only speak from experience, it never turned out to be a good idea for larger projects and was removed at some point in the project.

@kommander
Copy link
Collaborator

@DanielHabenicht just realised... we already have root relative paths https://github.com/CovOpen/CovMapper/blob/master/src/App.tsx#L17

@DanielHabenicht
Copy link
Collaborator Author

@DanielHabenicht just realised... we already have root relative paths https://github.com/CovOpen/CovMapper/blob/master/src/App.tsx#L17

than i will run a format command to make it look the same everywhere.

@DanielHabenicht DanielHabenicht added could have Small improvements that are nice to have but not necessary and removed triage Lets talk about this before doing it! labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could have Small improvements that are nice to have but not necessary enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants