Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug -- Map: prevent re-render when switching routes #79

Open
abettermap opened this issue Jun 4, 2020 · 0 comments
Open

🐛 Bug -- Map: prevent re-render when switching routes #79

abettermap opened this issue Jun 4, 2020 · 0 comments
Labels
effort: 4 (high) Much work required, may need to break out focus: functionality Requires script changes (TypeScript or JS), e.g. handle form submission, fetch API endpoint, etc. focus: ui/design Style or user-interface changes priority: 1 (wishlist) Some day! type: bug Something isn't working

Comments

@abettermap
Copy link
Contributor

abettermap commented Jun 4, 2020 •
edited
Loading

Description

Not really a bug but... it's annoying that your map position and (eventually if/when we have a control for it) current symbology is lost when you leave the map page and come back.

Expected behavior

Map view should stay as-is when switching between pages.

How to reproduce the problem

  1. Zoom in on the map.
  2. Go to About page.
  3. ...then back to map.

Zoom and extent are back to the initial.

Related items

Jira CSR-64

Resolution

Sub-routes do not see the way to go here, but maybe in react-router v6.

Jason idea: rm map from route. Show 24/7, but have all non-map non-modal routes in a <Switch> component inside a generic layout component with zIndex higher than map.
@abettermap abettermap added type: bug Something isn't working effort: 4 (high) Much work required, may need to break out priority: 1 (wishlist) Some day! focus: ui/design Style or user-interface changes focus: functionality Requires script changes (TypeScript or JS), e.g. handle form submission, fetch API endpoint, etc. labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: 4 (high) Much work required, may need to break out focus: functionality Requires script changes (TypeScript or JS), e.g. handle form submission, fetch API endpoint, etc. focus: ui/design Style or user-interface changes priority: 1 (wishlist) Some day! type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abettermap