Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential dead code? #86

Closed
izgzhen opened this issue Nov 14, 2018 · 2 comments
Closed

potential dead code? #86

izgzhen opened this issue Nov 14, 2018 · 2 comments

Comments

@izgzhen
Copy link
Collaborator

izgzhen commented Nov 14, 2018

def set_arg(stk):

this closure has an argument stk but not using it

@Calvin-L
Copy link
Collaborator

The inner set_arg function is appended to the list of operations to perform. Each operation must be a function that accepts a stack of values as input. Operations are allowed to manipulate the stack. This operation happens not to manipulate the stack, but if you remove the argument the code will crash because a stack will be passed by the caller.

@Calvin-L
Copy link
Collaborator

This might be clearer if we had type annotations in the evaluation module (see #50).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants