Skip to content

Commit

Permalink
fix e2e build failing on gh... hopefully?
Browse files Browse the repository at this point in the history
  • Loading branch information
LankyMoose committed Nov 24, 2024
1 parent b81f1d4 commit 82c13f5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ dt:
pnpm --filter "./packages/vite-plugin-kaioken" run build

test:
NODE_ENV=development pnpm --filter !"./sandbox/*" run -r test
NODE_ENV=development pnpm --filter !"./sandbox/*" run -r --parallel test

test_lib:
NODE_ENV=development pnpm --filter "./packages/lib" run -r --parallel test
4 changes: 2 additions & 2 deletions e2e/src/Counter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@ import { useState } from "kaioken"
export function Counter() {
const [toggled, setToggled] = useState(false)
return (
<>
<div>
{/* used for checking that counter persists state after reordering these children */}
{toggled && <p>Toggled</p>}
<ActualCounter />
<button id="toggle-btn" onclick={() => setToggled(!toggled)}>
toggle
</button>
</>
</div>
)
}

Expand Down
4 changes: 2 additions & 2 deletions e2e/src/KeyedList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ interface KeyedCounterProps {
function KeyedCounterItem({ id, remove }: KeyedCounterProps) {
const [count, setCount] = useState(0)
return (
<>
<div>
id : {id}
<div className="flex gap-2 px-2 bg-black bg-opacity-30">
<button
Expand All @@ -52,6 +52,6 @@ function KeyedCounterItem({ id, remove }: KeyedCounterProps) {
<button className="remove btn btn-primary" onclick={remove}>
Remove
</button>
</>
</div>
)
}
4 changes: 2 additions & 2 deletions sandbox/csr/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import kaioken from "vite-plugin-kaioken"

export default defineConfig({
ssr: {
external: ["kaioken"],
//external: ["kaioken"],
},
optimizeDeps: {
exclude: ["kaioken"],
//exclude: ["kaioken"],
},
esbuild: {
sourcemap: false,
Expand Down

0 comments on commit 82c13f5

Please sign in to comment.