Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider "falcon shell" without arguments automatically connecting to all hosts #52

Open
TannerFilip opened this issue May 25, 2023 · 1 comment
Assignees
Labels
🙌 enhancement New feature or request

Comments

@TannerFilip
Copy link

It seems like a strange choice to have argument-less falcon shell automatically connect to all hosts on the instance, especially when falcon profiles and falcon policies both print the help. I think it would make more sense for it to print the help information if run without arguments/options, and then require --all for it to connect to all hosts.

Since this could be a breaking change to some workflows, an alternative may be to put a(n overridable) short sleep in, so you have time to kill the process before it starts attempting to connect to the hosts.

@ChristopherHammond13 ChristopherHammond13 self-assigned this May 26, 2023
@ChristopherHammond13
Copy link
Member

Thank you for raising this! There is definitely an inconsistency here.

I'm wondering whether I'm leaning more towards providing help for a base command, or towards doing something useful. falcon host_search currently gives you all hosts if no filters are applied; falcon shell connects to all hosts; but falcon profiles does not unless you provide the sub-command list. In reality, list shouldn't really be needed for that.

I think policies will always be a special case since it multiplexes out into response and prevention. I'll have a chat to the others and see which path we end up going down. Either way, I agree it should be at very least consistent.

@ChristopherHammond13 ChristopherHammond13 added the 🙌 enhancement New feature or request label May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙌 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants