Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not catch some initial page load cases #62

Open
MichalBryxi opened this issue Aug 4, 2021 · 0 comments
Open

Does not catch some initial page load cases #62

MichalBryxi opened this issue Aug 4, 2021 · 0 comments

Comments

@MichalBryxi
Copy link

MichalBryxi commented Aug 4, 2021

The problem

On initial page load (or empty cache & hard page reload) the scroll to hash does not happen. In other cases (navigation, soft page reload, ...) it works.

Observations

  • Happens only on "empty cache & hard reload"
  • We get pass the uiSettled function call
  • We see the "Tried to scroll to element with id or name "${hash}", but it was not found" message in the console, but:
  • The element with given ID is eventually present; On subsequent soft page reload everything works
  • If we pause in debugger just before the warning message (above) then we can see that the UI is not fully settled (loading spinners and such)
  • If we try to debug the steps we can see that uiSettled returns before all the route models resolve
MichalBryxi pushed a commit to MichalBryxi/ember-url-hash-polyfill that referenced this issue Aug 4, 2021
MichalBryxi pushed a commit to MichalBryxi/ember-url-hash-polyfill that referenced this issue Aug 4, 2021
MichalBryxi pushed a commit to MichalBryxi/ember-url-hash-polyfill that referenced this issue Aug 4, 2021
- Currently failing, because there is a bug on initial render
- Hopefully they are conclusive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant