You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#297 added conditional templating for several values in the config. However the check is not valid when the variable is a boolean:
#confirm_instance = true
{{- if .Values.push.aws_security_hub.confirm_instance }}
confirm_instance = {{ .Values.push.aws_security_hub.confirm_instance }}
{{- end }}
{{- if .Values.push.aws_security_hub.confirm_instance }} is only evaluated as true if confirm_instance is set to true. So it makes it impossible to ever override the default true value and set it to false. It should check the value is defined, not if it is true.
The text was updated successfully, but these errors were encountered:
#297 added conditional templating for several values in the config. However the check is not valid when the variable is a boolean:
{{- if .Values.push.aws_security_hub.confirm_instance }}
is only evaluated as true ifconfirm_instance
is set to true. So it makes it impossible to ever override the default true value and set it to false. It should check the value is defined, not if it is true.The text was updated successfully, but these errors were encountered: