Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional templating broken for confirm_instance #300

Closed
mkeats-clumio opened this issue Jul 2, 2024 · 0 comments · Fixed by #301
Closed

Conditional templating broken for confirm_instance #300

mkeats-clumio opened this issue Jul 2, 2024 · 0 comments · Fixed by #301

Comments

@mkeats-clumio
Copy link

#297 added conditional templating for several values in the config. However the check is not valid when the variable is a boolean:

#confirm_instance = true
{{- if .Values.push.aws_security_hub.confirm_instance }}
confirm_instance = {{ .Values.push.aws_security_hub.confirm_instance }}
{{- end }}

{{- if .Values.push.aws_security_hub.confirm_instance }} is only evaluated as true if confirm_instance is set to true. So it makes it impossible to ever override the default true value and set it to false. It should check the value is defined, not if it is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant