Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow roles helper to take an array of strings #281

Open
kellyselden opened this issue Apr 21, 2020 · 1 comment
Open

allow roles helper to take an array of strings #281

kellyselden opened this issue Apr 21, 2020 · 1 comment

Comments

@kellyselden
Copy link
Collaborator 

roles('#foo #bar #baz', function() {

into

let _roles = [
  '#foo',
  '#bar',
  '#baz'
].join(' ');

roles(_roles,  function() {

into

roles('#foo', '#bar', '#baz', function() {

or

roles(
  [
    '#foo',
    '#bar',
    '#baz'
  ],
  function() {

cc @MichalBryxi
@MichalBryxi
Copy link

Dibs on this ☝️

MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue May 11, 2020
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
5f62b42 
Supported format:
 - Array of strings
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jun 24, 2020
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
6c3d9c9 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jun 26, 2020
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
bb5d19b 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jun 26, 2020
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
8104c36 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
671ae88 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
fix(CrowdStrike#281): rebase fixes
164789f
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
1294cee 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
68eacd2 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
abe8ba8 
Supported format:
 - Concatenated string
 - Multiple arguments
MichalBryxi added a commit to MichalBryxi/faltest that referenced this issue Jan 23, 2021
@MichalBryxi
feat(CrowdStrike#281): flexible roles helper
10462dc 
Supported format:
 - Concatenated string
 - Multiple arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellyselden @MichalBryxi