Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] Broken in 5.X+ #11

Open
OdinVex opened this issue Dec 4, 2022 · 5 comments
Open

[Critical] Broken in 5.X+ #11

OdinVex opened this issue Dec 4, 2022 · 5 comments

Comments

@OdinVex
Copy link
Contributor

OdinVex commented Dec 4, 2022

Broken for 5.1, complains of a header file not being found.

./ConsoleEnhanced/Source/ConsoleEnhanced/Private/SOutputLog.cpp:16:10: fatal error: 'Classes/EditorStyleSettings.h' file not found

I removed that because it doesn't belong in the cpp to begin with and simply corrected SOutputLog.h to include #include "Settings/EditorStyleSettings.h", it now sees the header correctly.

Edit: Side note, you have a ton of deprecated calls (21). You require a small bit of rewriting, as these calls were deprecated in 5.0.

Edit: Compilation will also be faster if you don't use monolithic headers such as EditorStyle.h or SlateBasics.h:

To handle this, I removed SlateBasics.h and added the following to SOutputLog.h:

#include "Widgets/Input/SMultiLineEditableTextBox.h"
#include "Framework/Text/SlateHyperlinkRun.h"
#include "Framework/Text/SlateTextRun.h"
#include "Misc/OutputDeviceHelper.h"
#include "SlateOptMacros.h" // To handle XXX_SLATE_FUNCTION_BUILD_OPTIMIZATION blocks

Edit: Also corrected #include "AssetRegistryModule.h" to #include "AssetRegistry/AssetRegistryModule.h"

Edit: LogTimestampMode no longer exists under UEditorStyleSettings, at least in a quick grep of source code. It has seen some work in 5.1. I added OutputLog to the list of PrivateDependencyModuleNames and OutputLogSettings.h to the list of includes in SOutputLog.h as well as changing UEditorStyleSettings to UOutputLogSettings. It compiles, I've untested it all.

@OdinVex
Copy link
Contributor Author

OdinVex commented Dec 4, 2022

I'll probably clone, do a pull-request with all changes necessary.

@SeanDavidS
Copy link

@OdinVex Did you manage to fix it so it could be run in 5.1? The code for this would be very appreciated!

@OdinVex
Copy link
Contributor Author

OdinVex commented Jun 9, 2023

@OdinVex Did you manage to fix it so it could be run in 5.1? The code for this would be very appreciated!

I did, but I'll need to find it if it wasn't lost in a RAID volume failure. I've been doing a lot of OS migration away from ancient *bian/*buntu and their derivatives to Arch-like distros. Keep in mind though that my edit is specific for Linux users to fix a crash.

@SeanDavidS
Copy link

SeanDavidS commented Jun 10, 2023

I did, but I'll need to find it if it wasn't lost in a RAID volume failure. I've been doing a lot of OS migration away from ancient *bian/*buntu and their derivatives to Arch-like distros. Keep in mind though that my edit is specific for Linux users to fix a crash.

I didn't see this as a specific fix for Linux users. So no need to dig to find it :) Thanks for your code anyway, I almost got it working on Windows with 5.1.1.

@OdinVex OdinVex changed the title [Critical] Broken in 5.1 [Critical] Broken in 5.X+ Sep 26, 2023
@OdinVex
Copy link
Contributor Author

OdinVex commented Sep 26, 2023

I did, but I'll need to find it if it wasn't lost in a RAID volume failure. I've been doing a lot of OS migration away from ancient *bian/*buntu and their derivatives to Arch-like distros. Keep in mind though that my edit is specific for Linux users to fix a crash.

I didn't see this as a specific fix for Linux users. So no need to dig to find it :) Thanks for your code anyway, I almost got it working on Windows with 5.1.1.

Found an old archive of what I got working on 5.1, updated it to 5.3. Maintaining a fork with those changes at https://github.com/OdinVex/ConsoleEnhanced (though I may need to be reminded when an update has occurred). Untested on Windows, should work, but I'm debugging a ton of other plugins, too. If you get issues, feel free to open up an Issue. It compiles, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants