From 0be73a743178cebc00bf733d3cd50a168b1fa281 Mon Sep 17 00:00:00 2001 From: maria-thom Date: Tue, 27 Aug 2024 21:01:35 +0100 Subject: [PATCH 1/2] Removes settlement_type from the Accounts API. --- .../sub-account-activity.md | 1 - .../v2_accounts_create_POST_200.json | 3 +-- .../v2_accounts_current_GET_200.json | 3 +-- .../responses/v2_accounts_find_GET_200.json | 27 +------------------ .../responses/v2_accounts_find_POST_200.json | 25 ----------------- .../responses/v2_accounts_id_GET_200.json | 3 +-- .../responses/v2_accounts_id_POST_200.json | 3 +-- src/reference.yaml | 7 ----- 8 files changed, 5 insertions(+), 67 deletions(-) diff --git a/data/local/pages/integration-guides/sub-account-activity.md b/data/local/pages/integration-guides/sub-account-activity.md index 9fbe0d6..de6f8a6 100644 --- a/data/local/pages/integration-guides/sub-account-activity.md +++ b/data/local/pages/integration-guides/sub-account-activity.md @@ -63,7 +63,6 @@ Response:     "online_trading": true,     "phone_trading": true,     "process_third_party_funds": false, -    "settlement_type": "net",     "agent_or_reliance": false,     "terms_and_conditions_accepted": null } diff --git a/data/local/swagger/responses/v2_accounts_create_POST_200.json b/data/local/swagger/responses/v2_accounts_create_POST_200.json index 95a7112..07f1ee7 100644 --- a/data/local/swagger/responses/v2_accounts_create_POST_200.json +++ b/data/local/swagger/responses/v2_accounts_create_POST_200.json @@ -20,8 +20,7 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" -} \ No newline at end of file +} diff --git a/data/local/swagger/responses/v2_accounts_current_GET_200.json b/data/local/swagger/responses/v2_accounts_current_GET_200.json index 3545f26..b79f699 100644 --- a/data/local/swagger/responses/v2_accounts_current_GET_200.json +++ b/data/local/swagger/responses/v2_accounts_current_GET_200.json @@ -20,8 +20,7 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" -} \ No newline at end of file +} diff --git a/data/local/swagger/responses/v2_accounts_find_GET_200.json b/data/local/swagger/responses/v2_accounts_find_GET_200.json index 57cd817..9a197ad 100644 --- a/data/local/swagger/responses/v2_accounts_find_GET_200.json +++ b/data/local/swagger/responses/v2_accounts_find_GET_200.json @@ -22,7 +22,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -49,7 +48,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -76,7 +74,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -103,7 +100,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -130,7 +126,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -157,7 +152,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -184,7 +178,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -211,7 +204,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -238,7 +230,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -265,7 +256,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -292,7 +282,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -319,7 +308,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -346,7 +334,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -373,7 +360,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -400,7 +386,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -427,7 +412,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -454,7 +438,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -481,7 +464,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -508,7 +490,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -535,7 +516,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -562,7 +542,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -589,7 +568,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -616,7 +594,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -643,7 +620,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -670,7 +646,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -686,4 +661,4 @@ "order": "created_at", "order_asc_desc": "asc" } -} \ No newline at end of file +} diff --git a/data/local/swagger/responses/v2_accounts_find_POST_200.json b/data/local/swagger/responses/v2_accounts_find_POST_200.json index f30d109..9a197ad 100644 --- a/data/local/swagger/responses/v2_accounts_find_POST_200.json +++ b/data/local/swagger/responses/v2_accounts_find_POST_200.json @@ -22,7 +22,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -49,7 +48,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -76,7 +74,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -103,7 +100,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -130,7 +126,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -157,7 +152,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -184,7 +178,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -211,7 +204,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -238,7 +230,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -265,7 +256,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -292,7 +282,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -319,7 +308,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -346,7 +334,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -373,7 +360,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -400,7 +386,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -427,7 +412,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -454,7 +438,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -481,7 +464,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -508,7 +490,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -535,7 +516,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -562,7 +542,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -589,7 +568,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -616,7 +594,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -643,7 +620,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" @@ -670,7 +646,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" diff --git a/data/local/swagger/responses/v2_accounts_id_GET_200.json b/data/local/swagger/responses/v2_accounts_id_GET_200.json index 18cf66b..5262e48 100644 --- a/data/local/swagger/responses/v2_accounts_id_GET_200.json +++ b/data/local/swagger/responses/v2_accounts_id_GET_200.json @@ -20,8 +20,7 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null, "bank_account_verified": "not required" -} \ No newline at end of file +} diff --git a/data/local/swagger/responses/v2_accounts_id_POST_200.json b/data/local/swagger/responses/v2_accounts_id_POST_200.json index 4c3d963..4504b56 100644 --- a/data/local/swagger/responses/v2_accounts_id_POST_200.json +++ b/data/local/swagger/responses/v2_accounts_id_POST_200.json @@ -20,7 +20,6 @@ "online_trading": true, "phone_trading": true, "process_third_party_funds": false, - "settlement_type": "net", "agent_or_reliance": false, "terms_and_conditions_accepted": null -} \ No newline at end of file +} diff --git a/src/reference.yaml b/src/reference.yaml index 305e2de..29311ac 100644 --- a/src/reference.yaml +++ b/src/reference.yaml @@ -16124,12 +16124,6 @@ definitions: process_third_party_funds: description: Is the account enabled for third party funds? type: boolean - settlement_type: - description: The settlement type - bulk or net. - enum: - - bulk - - net - type: string terms_and_conditions_accepted: description: Have the terms and conditions been accepted? type: boolean @@ -16165,7 +16159,6 @@ definitions: online_trading: true phone_trading: true process_third_party_funds: false - settlement_type: bulk terms_and_conditions_accepted: true agent_or_reliance: true bank_account_verified: no From 730ca6da5f358056acbcdd3d3b63586b30b49dc8 Mon Sep 17 00:00:00 2001 From: maria-thom Date: Tue, 27 Aug 2024 21:09:21 +0100 Subject: [PATCH 2/2] Re-words endpoint names --- src/reference.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/reference.yaml b/src/reference.yaml index 29311ac..dceeafc 100644 --- a/src/reference.yaml +++ b/src/reference.yaml @@ -1450,7 +1450,7 @@ paths: tags: - Accounts x-api-group: manage - summary: Get the Payment Charges Settings for a given account + summary: Get Payment Charges Settings description: Retrieves the Payment Charges Settings for the given account. operationId: GetAccountPaymentChargesSettings produces: @@ -1564,7 +1564,7 @@ paths: tags: - Accounts x-api-group: manage - summary: Manage Account Payment Charges Settings + summary: Manage Payment Charges Settings description: Manage a given account's Payment Charge Settings (enable, disable, set as default). operationId: ManageAccountPaymentChargesSettings produces: