Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translations #428

Open
guyluz11 opened this issue Oct 3, 2022 · 33 comments
Open

Adding translations #428

guyluz11 opened this issue Oct 3, 2022 · 33 comments
Labels
good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang

Comments

@guyluz11
Copy link
Member

guyluz11 commented Oct 3, 2022

Hi

Do you want to help open source project?, or perhaps you're looking for easy pull request!.

If you know how to write this is your chance, lets get down to it.

First locate your language in this page.
Now remember the Language (two letter) - Region (two capital letters) of your region.

In this folder you will see files with the names of the Language-Region, if yours does not exist please create a new file for it.

Even if the language already exists but your region is not it is ok to open pull request, for example:
en-GB
it will be accepted because it is not en-US which already exists.

So how do you do it:

Language file does not exist

  1. In this folder copy the en-US.json (as it is our base to translate) and change the name of the copy to your Language-Region.

  2. Change the right side of the text to your language, you should keep the {} in the same place inside the word as it is a place holder.

  3. Open the pull request to the dev branch.

Language file exists

  1. Copy all missing translations from en-US.json into your existing Language file that we located earlier.

  2. Change the right side of the text to your language, you should keep the {} in the same place inside the word as it is a placeholder.

  3. Open the pull request to the dev branch.

If you have any questions you can ask me on the Discord server

  • Specifically for this issue there is no need to ask to be assigned, just open pr.
@guyluz11 guyluz11 added good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang labels Oct 3, 2022
@Antibodyy
Copy link
Contributor

Ill take it up!

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 3, 2022

Ill take it up!

Greate @Antibodyy, just open pr.
Just for this issue we do not assign it to people, I will add a Hacktoberfest-accepted label to the pr's and it will count for you.

@ojninja16
Copy link
Contributor

I would also like to work on it....

@AnshikaAnand222
Copy link
Contributor

I would like to work in this.

@AnshikaAnand222
Copy link
Contributor

I corrected some of the lines in hi-IN where there were mistakes in language please merge my pull request

@arefathi
Copy link
Contributor

arefathi commented Oct 3, 2022

Hello again @guyluz11
I have submitted a PR for the Amharic language under #437
Thanks for the opportunity. Appreciate it.

@boringdeveloper
Copy link
Contributor

Hello, I have opened PR #438 to add Filipino language translation.

@InquisitiveMe15
Copy link
Contributor

Hello! @guyluz11
I have added a few more translations in hi-IN.json that were missing in that file.
For this I have opened PR #452 .
Kindly merge my pull request.
Thank you!

@Cesar-M-Diaz
Copy link
Contributor

Hi ! I just added the es-US translation.
Here's the PR for that change #460, let me know if you need anything else :)
Thanks for the opportunity !

@Akhil-blanc
Copy link
Contributor

hey! I just added the ja-JP translation.
I opened PR #462, for the change.
Thanks for the opportunity.

@vinayjain18
Copy link
Contributor

Hello @guyluz11 ,
I have added the Malayalam language under PR #470
Thanks for the opportunity

@Heismanish
Copy link

Hey @guyluz11 , completed hindi translation and made a pr here #492 .

@lemmoor
Copy link
Contributor

lemmoor commented Oct 5, 2022

Hi, I have opened PR #497 to add Ukrainian translation.
Thanks for the opportunity

@goobric
Copy link
Contributor

goobric commented Oct 6, 2022

how do I open a pull request (PR) to the dev branch, for a language that does not exit in the folder?
I have created the .json file, the translation states that I do not have access to add a new language; and created a forked copy to my github account. How do I create a PR with this forked copy? thank you

@gnud-gnaoh
Copy link
Contributor

Hi @guyluz11, I have added the Vietnamese translation #502. Thanks! 😎

@magmukendi
Copy link
Contributor

I have also added French - Democratic Republic of the Congo's translation #503. Thanks @guyluz11

Utsav1999 pushed a commit to Utsav1999/cbj_app that referenced this issue Oct 8, 2022
guyluz11 added a commit that referenced this issue Oct 8, 2022
Utsav1999 pushed a commit to Utsav1999/cbj_app that referenced this issue Oct 8, 2022
@Utsav1999
Copy link
Contributor

how do I open a pull request (PR) to the dev branch, for a language that does not exit in the folder? I have created the .json file, the translation states that I do not have access to add a new language; and created a forked copy to my github account. How do I create a PR with this forked copy? thank you

Hello @goobric ,

As you said you have forked the repo, so now you need to make your desired changes and then you need to push the changes on your branch. Then create a pull request to the dev branch of the original repo from your branch and you are done 🎉

P.S.: To select the dev branch, you need to click on the dropdown option against the original repo name.

Thank you.

Utsav1999 pushed a commit to Utsav1999/cbj_app that referenced this issue Oct 8, 2022
guyluz11 added a commit that referenced this issue Oct 8, 2022
@minna-xD
Copy link
Contributor

minna-xD commented Oct 8, 2022

As someone with a background in the translation & localization industry, translation is not "super easy". It is often surprisingly tricky! 😉
In any case, I just started working on a Finnish translation. 🎃

By the way, I have trouble finding this in the app/code to explain the usage:
"Exist": "Exist",
Could someone help?

@guyluz11
Copy link
Member Author

guyluz11 commented Oct 8, 2022

As someone with a background in the translation & localization industry, translation is not "super easy". It is often surprisingly tricky! wink In any case, I just started working on a Finnish translation. jack_o_lantern

By the way, I have trouble finding this in the app/code to explain the usage: "Exist": "Exist", Could someone help?

It's easy from a git stand point XD.
Some usages of translations like Exist got deleted from the app, we are keeping the translations file with the same translations so that it will be easy to know how many translations are missing from each language (without deleting the world from all of the translations).

So just use the most common translation for the word and in the future if it is wrong someone will fix it.

And thank you everybody for your translations, it is one of the things that will help people around the world feel at home in our app.

@ziarparvaiz
Copy link
Contributor

Hi @guyluz11, I have added the Turkish translation #516. Thanks! 😎

@neocollege neocollege mentioned this issue Oct 9, 2022
Utsav1999 added a commit to Utsav1999/cbj_app that referenced this issue Oct 9, 2022
Hello,

I have updated hi-PK.json with the missing translasions.

Thank you.
guyluz11 added a commit that referenced this issue Oct 9, 2022
Utsav1999 pushed a commit to Utsav1999/cbj_app that referenced this issue Oct 9, 2022
guyluz11 added a commit that referenced this issue Oct 9, 2022
@KatiaAsh
Copy link
Contributor

Hi @guyluz11
I have added Arabic - Palestine's translation
PR: #528
Thanks

@goobric
Copy link
Contributor

goobric commented Oct 14, 2022 via email

@Utsav1999
Copy link
Contributor

Thank you for your reply How do I create a pull request to the repository once the en-US.json file has been altered for an additional language? Sorry for asking such a silly dumb question! I have the new language .json file, I don't know how to share it. Instruction 3 just states: "Open a pull request to the Dev branch"; without explaining how to do this! Sorry again, from a non-tech person.

On Sat, Oct 8, 2022, 17:58 Utsav Akash Naskar @.> wrote: how do I open a pull request (PR) to the dev branch, for a language that does not exit in the folder? I have created the .json file, the translation states that I do not have access to add a new language; and created a forked copy to my github account. How do I create a PR with this forked copy? thank you Hello @goobric https://github.com/goobric , As you said you have forked the repo, so now you need to make your desired changes and then you need to push the changes on your branch. Then create a pull request to the dev branch of the original repo from your branch and you are done 🎉 P.S.: To select the dev branch, you need to click on the dropdown option against the original repo name. Thank you. — Reply to this email directly, view it on GitHub <#428 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQR2BQYB7NMX6O35DV6VNLWCGKZPANCNFSM6AAAAAAQ3MMGSE . You are receiving this because you were mentioned.Message ID: @.>

Hello @goobric ,

It's great to see that you want to make opensource contributions. Please find the steps below.

  • In this repository move to the directory: cbj_app/assets/translations

  • There you will find a dropdown saying Add File and then after clicking on the dropdown you will find an option saying Create new file, click on this option.
    github

  • Now give the new file a valid name and paste the content in the appropriate place.

  • Make the commit using the button named Propose new file given below.

  • Now raise the PR by selecting the dev branch of the repo.
    github-1

Thank you.
Utsav

IvySaskia added a commit to IvySaskia/cbj_app that referenced this issue Oct 17, 2022
guyluz11 added a commit that referenced this issue Oct 17, 2022
@Akhil-blanc
Copy link
Contributor

hey! I just added the af-ZA translation.
I opened PR #570 , for the change.
Thanks for the opportunity.

@prabhleenn
Copy link

Hey ! I would love to work on this by making my first Hacktoberfest submission.
It would be great if you assign me this.

@guyluz11
Copy link
Member Author

Hey, @prabhleenn just open pr and I will check it, no need to be assigned.

@prabhleenn
Copy link

hey! I just added the en-HT translation.
I opened PR #589,
Thanks for the opportunity.

@Bikramjit21
Copy link
Contributor

idk why pr got blocked, its saying not allowing authorised users

@Utsav1999
Copy link
Contributor

Hello @Bikramjit21 , You need to make the PR to the dev branch and as you are a first time contributor so you need approval from the repo owner to merge your changes. Thank you.

@guyluz11
Copy link
Member Author

idk why pr got blocked, its saying not allowing authorised users

As @Utsav1999 said please change pr to dev branch, the merge itself and running the ci is done by one of the repo maintainer.

@prashantSj789
Copy link

I would like to work on this

@guyluz11
Copy link
Member Author

I would like to work on this

Great, waiting for pr

@prashantSj789
Copy link

I have submitted the PR with Hindi translation the state language of India

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Support Hacktoberfest open source event https://hacktoberfest.digitalocean.com/ super easy Super easy issue that can be solved even by programmers that not familiar withe the programming lang
Projects
None yet
Development

No branches or pull requests