New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative index into stateTable? #113

Open

chhu opened this issue Jun 13, 2023 · 1 comment

chhu commented Jun 13, 2023 •

edited

Loading

This is more a question:
How can you guarantee that this index to stateTable cannot become negative?

FiniteStateEntropy/lib/fse.h

Line 520 in 7149fa4

    
           statePtr->value = stateTable[ (statePtr->value >> nbBitsOut) + symbolTT.deltaFindState];

Thanks!

madMAx43v3r commented Nov 20, 2023

I've gotten segfaults here as well, usually when using more than 128 symbols.

I changed the code to check for out of range index and throw an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment