Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file not not applied in delta #4

Open
vetruvet opened this issue Sep 23, 2014 · 1 comment
Open

New file not not applied in delta #4

vetruvet opened this issue Sep 23, 2014 · 1 comment

Comments

@vetruvet
Copy link

Files not present in base file but are added in the input file are not applied in the output delta. The new file is present in the resulting delta zip but is not applied in the updater-script.

Example:
v1.zip: /system/test.txt, /system/test-delete.txt
v2.zip: /system/text.txt (modified), /system/test-new.txt
Resulting delta will apply patch for test.txt and delete test-delete.txt, but test-new.txt will not be extracted to /system. /system/test-new.txt is present in the delta zip but not applied in the updater-script.

For this example, the updater-script will have:

ui_print("Verifying current system...");
apply_patch_check("/system/test.txt", ...) || abort("\"/system/test.txt\" has unexpected contents.");
ui_print("Patching system files...");
apply_patch("/system/test.txt", "-", ..., package_extract_file("patch/system/test.txt.p"));
ui_print("Removing files...");
delete("system/test-delete.txt");

It should also extract /system/test-new.txt

@antdking
Copy link
Member

ah yes, I know about it. just every time I'm at a computer to fix it, I've forgotten about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants