[Crash] UnsupportedOperationException at org.cyclops.evilcraft.core.client.model.BroomModelBaked.handleBlockState

[pietro-lopes]

Issue type:

• 🐛 Bug

---

Short description:

Crash when placing Broom on Advanced Ae Reactor Chamber

Steps to reproduce the problem:

it is possible to right click the reactor chamber from advanced ae with a broom, the broom is placed within and that causes whoever tries to look at the block to crash

Expected behaviour:

No crash.

---

Versions:

• This mod: 1.2.65-594
• Minecraft: 1.21.1
• Mod loader version: Neoforge 21.1.116

Log file:

https://gnomebot.dev/paste/mclogs/NElXcg2#L3297

[rubensworks]

Thanks for reporting!

[rubensworks]

I see you're using embeddium, which modifies item rendering.
Please report this to their issue tracker, as it looks like they are not taking into account ItemOverrides.

[rubensworks]

Do let me know in case the embeddium mod author disagrees with my findings, as I'm definitely open to making changes if really needed. But this seems unlikely, as I've been using the same rendering logic here for several years now.

[pietro-lopes]

@FiniteReality Can you please take a look on this issue?

[FiniteReality]

This is actually a bug in AdvancedAE - they're not using the correct method to grab the item model: https://github.com/pedroksl/AdvancedAE/blob/master/src/main/java/net/pedroksl/advanced_ae/client/renderer/ReactionChamberTESR.java#L191

Specifically, ItemModelShaper#getItemModel() doesn't respect model overrides, meaning they're passing the wrong model to render in the first place. I think this would also crash without Embeddium too.

GitHub

AdvancedAE/src/main/java/net/pedroksl/advanced_ae/client/renderer/ReactionChamberTESR.java at master · pedroksl/AdvancedAE

An AE2 addon that adds a lot of utilities and quality of life - pedroksl/AdvancedAE