-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor config.py
#120
Comments
I can try to refactor this file |
It might not be worth it tbh. If you want to, go for it, but there are more important things to work on too! |
Well, I have made a PR after trying a lot of things, but I was not doing it the right way... I was trying to solve everything at the same time and went back to the start. So for now I have made a simple rework just to propose a "simple solution". I'll let that to other contributors or future improvements. It can maybe help to start something! I'll be checking other issues later, I should get back to the course! EDIT: I have asked in the PR, but maybe it is better here. I would like to test it with the integration workflow. Do we set up the keys inside a 1. `ETHERSCAN_API_KEY` set to an Etherscan API key
2. `OPTIMISTIC_ETHERSCAN_API_KEY` set to an Etherscan-Optimism API key |
That is one option. What you'd do, is you'd add everything into a Optionally, you could also just directly activate them in your shell. For extra security, you could encrypt them with a CLI password manager like pass, encrypt them, and then run a script to activate them in your shell. This might be overkill for these API keys, as they don't have access to much. |
RIght now, it's a beeegggggg file. It would be great to split up those classes into 3 separate files.
The text was updated successfully, but these errors were encountered: