Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Export separartor problem #22

Open
pepisp opened this issue Jan 9, 2018 · 5 comments
Open

CSV Export separartor problem #22

pepisp opened this issue Jan 9, 2018 · 5 comments
Labels

Comments

@pepisp
Copy link

pepisp commented Jan 9, 2018

When exporting data from query to csv all floats have commas which conflicts with separator. So such file is useless as one have to do some extra postprocessing. Example:
01.11.2017 00:00:02,0,02375,0,19375,12
it should look like:
01.11.2017 00:00:02,0.02375,0.19375,12
Alternatively you can change the separator to ";", or let user decide what separator to use.

@meverett
Copy link
Collaborator

I can't reproduce this locally, what language settings are you using? It might be that .NET is choosing to localize numbers with commas instead of decimal points based on localization settings native to the OS.

@meverett
Copy link
Collaborator

Are you able to build from source? I have a fix in a new branch that you could checkout and build from and see if this fixes the issue. If it does I'll merge into master. I can't reproduce it locally so your help would be appreciated.

When I have more time I'm definitely open to a user selectable delimiter/separator.

@meverett meverett added the bug label Jan 12, 2018
@pepisp
Copy link
Author

pepisp commented Jan 12, 2018

You are right that it is due to local float settings as in Poland (I think in whole Europe) we use commas as decimal symbol. Your fix just changed datetime format to : 2018-01-12T08:00:02.0000000Z. But nothing has changed in floats. However when I manually changed decimal symbol in system settings to "." export is then correct.
So a kind of hotfix is to change system setting, but this doesn't fix the problem.

@meverett
Copy link
Collaborator

I'm working on introducing user editable formats for date, time, decimal/float/double, and integer, as well as CSV delimiter/separator. This will be part of the user settings. It'll take me a little bit to have to time to finish, but I've got it started. I'll let you know when there's an update and maybe you can test again that it resolves your issue. Thanks!

@pepisp
Copy link
Author

pepisp commented Jan 15, 2018

OK, so let me know,when there will be something to test. For now I will use the system settings hack :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants