Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fixtures): support for mongodb embeddables #14

Closed
wants to merge 1 commit into from

Conversation

xdave
Copy link

@xdave xdave commented Sep 13, 2021

  • works with the object: true option
  • does not include support for the array: true option

TL;DR: @mikro-resources/fixtures now respects the object: true option when generating properties for embeddables (which is commonly used for mongodb subdocuments).

However, I may need some guidance on how to generate an array of subdocuments, which I have not been able to figure out.

 - works with the `object: true`
 - does not include support for the `array: true` option
@CyriacBr
Copy link
Owner

Hello, thanks for the PR.
However, I'm currently working on the next major version of class-fixtures-factory, the underlying library this package uses.
With this next version, I will deprecate mikro-resources and MikroORM factoy will be available through a plugin inside of class-fixtures-factory itself.

It would be great if:

If not, I'll port your changes there myself eventually. But I'd appreciate if you could try the new factory and provide feedback =)

@CyriacBr CyriacBr closed this Sep 15, 2021
@CyriacBr
Copy link
Owner

By the way, there is a chance the new factory already supports what you're after. Will confirm when I find the time to review your changes.

@xdave
Copy link
Author

xdave commented Sep 16, 2021

@CyriacBr excellent! I will take a look and report back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants