Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some improvements #1

Open
amotl opened this issue Jan 31, 2021 · 3 comments
Open

Add some improvements #1

amotl opened this issue Jan 31, 2021 · 3 comments

Comments

@amotl
Copy link

amotl commented Jan 31, 2021

Dear @Czaki,

thanks for your excellent work building upon @cgohlke's imagecodecs here. Coming from pypa/cibuildwheel#568 (comment) ff. (thanks again!), I wanted to leave a note here in order to come back to this later.

I took a quick look at these images, specifically the 32-bit variant bokota/imagecodecs_i686 in comparison to the bokota/imagecodecs_64 variant, and found that even more libraries are installed than those you listed. Let me write down a short summary about my findings.

Installed libraries

  • find / -iname '*hdf5*' shows that libhdf5 is installed within both image variants.
  • find / -iname '*lzo*' shows that liblzo is installed within bokota/imagecodecs_64, but not within bokota/imagecodecs_i686.
  • find / -iname '*blosc*' shows that libblosc is not installed into standard system locations.

Using yum

Regarding yum croaking, as outlined at pypa/cibuildwheel#568 (comment), I have been able to fix it ad hoc by adjusting /etc/yum.repos.d/CentOS-Base.repo like [1]

baseurl=https://vault.centos.org/6.10/os/$basearch/
baseurl=https://vault.centos.org/6.10/updates/$basearch/
baseurl=https://vault.centos.org/6.10/extras/$basearch/
baseurl=https://vault.centos.org/6.10/centosplus/$basearch/
baseurl=https://vault.centos.org/6.10/contrib/$basearch/

With kind regards,
Andreas.

[1] https://forums.cpanel.net/threads/yumrepo-error-and-cannot-find-valid-baseurl.682465/

@Czaki
Copy link
Owner

Czaki commented Feb 1, 2021

In this project all libraries are installed in:
/opt/imagecodecs/build_utils/libs_build/lib

but C_INCLUDE_PATH and LD_LIBRARY_PATH are modified. I decide to do this way to use the same scripts inside docker and for userspace installation. I'm not sure how Docker COPY work and if I could use it to install in standard location.

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
PATH="/usr/local/opt/gettext/bin:$PATH"
build_dir=${DIR}/libs_build

I do some refactor of Dockerfile to use multistage build and got a reduction of image size.
You may try 2021.2.1 version of image.

@amotl
Copy link
Author

amotl commented Feb 2, 2021

C_INCLUDE_PATH and LD_LIBRARY_PATH are modified.

So it will do no harm even when installed within non-standard locations, right? Thanks for clarifying!

@Czaki
Copy link
Owner

Czaki commented Feb 2, 2021

So it will do no harm even when installed within non-standard locations, right? Thanks for clarifying!

My experience show that it not harm. It also allow to use other version than installed in system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants