Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Persistence Frequency #469

Open
elijahbenizzy opened this issue Dec 11, 2024 · 0 comments
Open

Configurable Persistence Frequency #469

elijahbenizzy opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@elijahbenizzy
Copy link
Contributor

elijahbenizzy commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
Currently we persist after every node. We should allow this to be configurable. This saves you from an over-saving state, which can cause slowness/state bloat.

Describe the solution you'd like
A few ideas:

  1. Add a filter in the with_persister argument -- probably node names (exclude/include)
  2. Add in the Action itself (E.G. have an action say if it should be persisted/tracked/transient)
  3. Integrate with tags (feature we don't have yet) -- have a tags=['no_persist'] or something -- see Tags for actions #468

So really, do we want this at the action or application level? My instinct is that we can have both but the action level is more valuable, need to think it through though...

Describe alternatives you've considered
See above + #468.

@elijahbenizzy elijahbenizzy added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant