Parallelism UI improvements

[elijahbenizzy]

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

• PR has an informative and human-readable title (this will be pulled into the release notes)
• Changes are limited to a single goal (no scope creep)
• Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future TODOs are captured in comments
• Project documentation has been updated if adding/changing functionality.

---

Important

Enhance parallelism UI by improving step navigation, sub-application handling, and insights display across multiple components.

• Behavior:
  • Modify AppListTable in AppList.tsx to display all apps, not just root apps.
  • Update AppView in AppView.tsx to handle SequenceLocation for step navigation.
  • Enhance AnnotationsView in AnnotationsView.tsx to support SequenceLocation for annotations.
• Components:
  • Add RecursionDepthPadding and SelfLoadingSubApplicationContainer in StepList.tsx for better sub-application handling.
  • Update WaterfallPiece in StepList.tsx to handle sub-actions.
  • Modify InsightSubTable in InsightsView.tsx to use SequenceLocation for insights.
• Utilities:
  • Add useLocationParams in utils.tsx for consistent URL parameter handling.
• Misc:
  • Import GraphBuilder in burr/core/__init__.py.
  • Remove unused useParams import in AppView.tsx.

^{This description was created by for f5106cb. It will automatically update as commits are pushed.}

[github-actions]

A preview of f5106cb is uploaded and can be seen here:

✨ https://burr.dagworks.io/pull/421 ✨

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/421/

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to a0241af in 1 minute and 42 seconds

More details

• Looked at 1868 lines of code in 8 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. telemetry/ui/src/components/routes/app/AppView.tsx:164

• Draft comment:
  Consider checking if searchParams.get('sequence_location') is not null or undefined before parsing it with JSON.parse to avoid potential runtime errors.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. telemetry/ui/src/components/routes/AppList.tsx:209

• Draft comment:
  There's a commented-out line for filtering rootAppsToDisplay. Ensure this is intentional and not left by mistake.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The AppListTable component has a commented-out line that filters rootAppsToDisplay. This might be intentional, but it's worth noting in case it was left unintentionally.

3. telemetry/ui/src/components/routes/app/AnnotationsView.tsx:193

• Draft comment:
  Ensure that setting highlightedSequence to currentEditingAnnotationContext.sequenceId is intentional when currentEditingAnnotationContext is undefined, as it defaults to undefined.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In AnnotationsView, the highlightedSequence prop is set to currentEditingAnnotationContext.sequenceId. However, if currentEditingAnnotationContext is undefined, it defaults to undefined. This might be intentional, but it's worth noting in case it was overlooked.

4. telemetry/ui/src/components/routes/app/AnnotationsView.tsx:174

• Draft comment:
  Ensure that setting highlightedSequence to currentEditingAnnotationContext.sequenceId is intentional when currentEditingAnnotationContext is undefined, as it defaults to undefined.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In AnnotationsView, the highlightedSequence prop is set to currentEditingAnnotationContext.sequenceId. However, if currentEditingAnnotationContext is undefined, it defaults to undefined. This might be intentional, but it's worth noting in case it was overlooked.

5. telemetry/ui/src/components/routes/app/AppView.tsx:263

• Draft comment:
  Double-check the logic for enabling currentFocusStepsData query to ensure it aligns with the intended behavior, especially the condition currentFocusAppID !== appID && currentFocusAppID !== undefined.
• Reason this comment was not posted:
  Confidence changes required: 50%
  In AppView, the currentFocusStepsData query is enabled based on currentFocusAppID !== appID && currentFocusAppID !== undefined. This logic might be correct, but it's worth double-checking to ensure it aligns with the intended behavior.

Workflow ID: wflow_nDiJuXmUy37yNsDW

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on f5106cb in 16 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_B8052Abi3FUqA5ft

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.